Skip to content

fix(curriculum): remove double punctuation marks at the end of sentences#65511

Merged
majestic-owl448 merged 7 commits intofreeCodeCamp:mainfrom
farchettiensis:fix/remove-double-punctuation-at-the-end-of-sentences
Feb 12, 2026
Merged

fix(curriculum): remove double punctuation marks at the end of sentences#65511
majestic-owl448 merged 7 commits intofreeCodeCamp:mainfrom
farchettiensis:fix/remove-double-punctuation-at-the-end-of-sentences

Conversation

@farchettiensis
Copy link
Copy Markdown
Contributor

@farchettiensis farchettiensis commented Jan 26, 2026

Checklist:

Closes #65383

Description

I've reviewed every single case mentioned in the referenced issue. Not all cases so clear-cut. Some of the search results listed are false positives, like punctuation that is part of a test assertion, in which case changing them would break the test. So I kept apparent double punctuation that is part of the code (another instance are regular expressions).

In other instances, the punctuation inside the backticks is part of the inner sentence, so there's really no punctuation conflict, as in Hello React!. The exclamation doesn't end the outer sentence.

Another case worth mentioning are ellipses that don't function as full stops, rather indicating that part of the sentence is being omitted.

I thought it was worth mentioning these cases. Let me know if anything needs to be corrected/reviewed!

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jan 26, 2026
@farchettiensis farchettiensis changed the title chore: remove double full stop punctuation marks fix(curriculum): remove double punctuation marks at the end of sentences Jan 26, 2026
@farchettiensis farchettiensis marked this pull request as ready for review January 26, 2026 17:03
@farchettiensis farchettiensis requested review from a team as code owners January 26, 2026 17:03
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. english for developers English Curriculum labels Jan 28, 2026
@nieldakarla nieldakarla removed the english for developers English Curriculum label Jan 28, 2026
Copy link
Copy Markdown
Contributor

@majestic-owl448 majestic-owl448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove changes to archived content, you can consider current content those in folders starting with lab-, workshop- or lecture-, and also project euler, rosetta, and the language curricula

@farchettiensis
Copy link
Copy Markdown
Contributor Author

please remove changes to archived content, you can consider current content those in folders starting with lab-, workshop- or lecture-, and also project euler, rosetta, and the language curricula

So I should be removing changes here:

  • curriculum/challenges/english/blocks/basic-javascript/
  • curriculum/challenges/english/blocks/es6/
  • curriculum/challenges/english/blocks/regular-expressions/

All the others should stay, if I understood correctly. Can you confirm?

@majestic-owl448
Copy link
Copy Markdown
Contributor

also curriculum/challenges/english/blocks/learn-html-by-building-a-cat-photo-app/

Copy link
Copy Markdown
Contributor

@majestic-owl448 majestic-owl448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add that while removing periods at the end of the paragraphs can be ok, removing them from inside paragraphs is not, it's going to disrupt the translations, please revert those changes

@farchettiensis
Copy link
Copy Markdown
Contributor Author

forgot to add that while removing periods at the end of the paragraphs can be ok, removing them from inside paragraphs is not, it's going to disrupt the translations, please revert those changes

I've reverted the cases you mentioned. I'm unsure about two remaining ones.

  1. curriculum/challenges/english/blocks/learn-how-to-talk-about-hobbies-and-interests/65802ee9706eb103aea442f8.md:
image
  1. curriculum/challenges/english/blocks/learn-how-to-use-prepositions-according-to-context/6839a6376e7c2c8f7ed40f2c.md:
image

Should these be reverted as well?

Other than that, I reviewed all the other cases.

@nieldakarla
Copy link
Copy Markdown
Contributor

forgot to add that while removing periods at the end of the paragraphs can be ok, removing them from inside paragraphs is not, it's going to disrupt the translations, please revert those changes

I've reverted the cases you mentioned. I'm unsure about two remaining ones.

  1. curriculum/challenges/english/blocks/learn-how-to-talk-about-hobbies-and-interests/65802ee9706eb103aea442f8.md:
image 2. `curriculum/challenges/english/blocks/learn-how-to-use-prepositions-according-to-context/6839a6376e7c2c8f7ed40f2c.md`: image Should these be reverted as well?

Other than that, I reviewed all the other cases.

The changes you made removing ... and . are correct, so we should keep them.

Copy link
Copy Markdown
Contributor

@majestic-owl448 majestic-owl448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 🎉

@majestic-owl448 majestic-owl448 merged commit 48e0f76 into freeCodeCamp:main Feb 12, 2026
11 checks passed
zairahira pushed a commit to zairahira/freeCodeCamp that referenced this pull request Feb 25, 2026
LGH831 pushed a commit to LGH831/freeCodeCamp that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double punctuation

4 participants