fix(curriculum): remove double punctuation marks at the end of sentences#65511
Conversation
So I should be removing changes here:
All the others should stay, if I understood correctly. Can you confirm? |
|
also |
majestic-owl448
left a comment
There was a problem hiding this comment.
forgot to add that while removing periods at the end of the paragraphs can be ok, removing them from inside paragraphs is not, it's going to disrupt the translations, please revert those changes
majestic-owl448
left a comment
There was a problem hiding this comment.
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 🎉




Checklist:
mainbranch of freeCodeCamp.Closes #65383
Description
I've reviewed every single case mentioned in the referenced issue. Not all cases so clear-cut. Some of the search results listed are false positives, like punctuation that is part of a test assertion, in which case changing them would break the test. So I kept apparent double punctuation that is part of the code (another instance are regular expressions).
In other instances, the punctuation inside the backticks is part of the inner sentence, so there's really no punctuation conflict, as in
Hello React!. The exclamation doesn't end the outer sentence.Another case worth mentioning are ellipses that don't function as full stops, rather indicating that part of the sentence is being omitted.
I thought it was worth mentioning these cases. Let me know if anything needs to be corrected/reviewed!