fix(curriculum): repair failing border test in form step 35#67044
Open
AyushK5ingh wants to merge 2 commits intofreeCodeCamp:mainfrom
Open
fix(curriculum): repair failing border test in form step 35#67044AyushK5ingh wants to merge 2 commits intofreeCodeCamp:mainfrom
AyushK5ingh wants to merge 2 commits intofreeCodeCamp:mainfrom
Conversation
github-actions
Bot
added
the
scope: curriculum
AyushK5ingh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #66939
Description
Fixes a false-failing test in Step 35 of the Parent Teacher Conference Form workshop. Users writing correct code (
border: none) were seeing test failures due to an overly broad assertion that also matched unintended values like'medium'and'medium none'.Demo:
https://github.com/user-attachments/assets/6856a469-b311-4cab-934c-85260e4b1711
Root Cause
The old assertion used
assert.oneOfto checkstyle?.getPropVal('border')against['none', 'medium', 'medium none']. This allowed incorrect values to pass and caused correctborder: nonedeclarations to fail in some browsers due to how computed styles are reported.Fix
Replaced with
assert.strictEqual(style?.borderBottomStyle, 'none')— a precise check on the specific CSS property that the step instruction targets.