fix(#523): dont error when VPN is disconnected externally - #526
Merged
Conversation
get_vpn_info() read the active connections state, devices, interface, and IP config with raw `?`. When a VPN is torn down externally (e.g. disconnected from another app) while being read, those objects vanish mid-read and NetworkManager returns an UnknownObject/UnknownInterface D-Bus error, which surfaced downstream (COSMIC Settings) as "a VPN interface does not exist". Treat missing-object reads as the VPN no longer being active (NoVpnConnection) and degrade interface/IP details gracefully, matching the existing vanish-handling in list_active_connections. Expose is_missing_dbus_object_error as pub(crate) and add a vanished_or_err helper with unit tests.
cachebag
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_vpn_info() read the active connections state, devices, interface, and IP config with raw
?. When a VPN is torn down externally (e.g. disconnected from another app) while being read, those objects vanish mid-read and NetworkManager returns an UnknownObject/UnknownInterface D-Bus error, which surfaced downstream (COSMIC Settings) as "a VPN interface does not exist".Treat missing-object reads as the VPN no longer being active (NoVpnConnection) and degrade interface/IP details gracefully, matching the existing vanish-handling in list_active_connections. Expose is_missing_dbus_object_error as pub(crate) and add a vanished_or_err helper with unit tests.
Closes #523