fix: Only show update message if current < latest#1499
Merged
Conversation
iuioiua
reviewed
Jul 24, 2023
marvinhagemeister
force-pushed
the
smever-sort
branch
from
74a5676 to
5c9bdcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that we still had a case where the cache has the old value latest and users may have just upgraded to a newer version than in the cache, that we'd still show the upgrade message. This was because we only checked if
current !== latest, which doesn't account for thecurrent > latest.Note that this only during the time interval between a new release and the next update check. Once the update check updates the cache we don't run in the situation where
current > latest.To address that I've added a basic semver comparison check.