fix: middleware state reset between middlewares#1500
Merged
Conversation
deer
suggested changes
Jul 23, 2023
deer
left a comment
deer
left a comment
Contributor
There was a problem hiding this comment.
Lovely fix! I'm surprised there weren't tests for this already.
Perhaps you should add a small note in the documentation? Right after The `ctx` also has a `state` property that can be used to pass arbitrary data to downstream (or upstream) handlers. you could add:
`State` is normally set by modifying its properties, e.g. `ctx.state.loggedIn = true`, but you can also modify the entire object like `ctx.state = { loggedIn = true }`. (Or something like that. Just to let people know that both options are available.)
marvinhagemeister
force-pushed
the
middleware-state
branch
from
87060be to
373b9cc
Compare
deer
reviewed
Jul 24, 2023
marvinhagemeister
force-pushed
the
middleware-state
branch
from
373b9cc to
25943c0
Compare
deer
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1497 .