Accessbility tweaks and fixes for docs/www#1507
Merged
Merged
Conversation
Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
section-tags should have a heading Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
marvinhagemeister
approved these changes
Jul 22, 2023
marvinhagemeister
left a comment
marvinhagemeister
left a comment
Contributor
There was a problem hiding this comment.
This is fantastic! Thank you so much for the PR 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First let me say thank you so much for Deno Fresh – it's a trill to use and learn!
With this PR I want to give back with some of my knowledge.
This PR focuses on accessibilty fixes that makes a screen reader read redundant stuff which can make it harder to understand what is being read.
To summarize:
aria-hidden="true"to a bunch of decorative icons.<LemonDrop />to be a<div>instead of<section>, as a section should have a heading and this element is purely a decorative feature (from w3c).If there are any questions, suggestions or anything, please let me know :)