Skip to content

fix: parse multiple route params in same part#1518

Merged
marvinhagemeister merged 2 commits into
mainfrom
route-parse
Jul 25, 2023
Merged

fix: parse multiple route params in same part#1518
marvinhagemeister merged 2 commits into
mainfrom
route-parse

Conversation

@marvinhagemeister

Copy link
Copy Markdown
Contributor

Our existing way to parse file paths to patterns for routes was a bit rudimentary. It only allowed parameters to be the full path segments:

Before:

  • foo/[bar]@foo -> foo/[bar]@foo

After:

  • foo/[bar]@foo -> foo/:bar@foo

Fixes #1516

Comment thread src/server/context.ts Outdated

@bartlomieju bartlomieju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit a5822a8 into main Jul 25, 2023
@marvinhagemeister marvinhagemeister deleted the route-parse branch July 25, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not found route with extension in the file name

3 participants