fix(server): change RouteContext data type parameter default to any#1536
Merged
marvinhagemeister merged 1 commit intoJul 28, 2023
Merged
Conversation
This was referenced Jul 28, 2023
marvinhagemeister
approved these changes
Jul 28, 2023
marvinhagemeister
left a comment
marvinhagemeister
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the PR 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1528
I have a large comment in 1528 explaining what's going on here.
During the course of researching this, I found
deno check **/*.tsto type check all the files in the project. It turns out we have this issue in our code base as well!tests/fixture_server_components/main.tsshows this exact error, becauseroutes/context/[id].tsxandroutes/fail.tsxdon't qualifyRouteContextwith any type parameters.In a soon-to-be-opened PR, I will suggest that we type check our entire project as part of CI. If we had always been doing this, then we would have caught this problem before users had to report an issue.