fix(ci): type error in dev_checks fixture#1550
Merged
Merged
Conversation
marvinhagemeister
approved these changes
Jul 31, 2023
Contributor
|
Whoops, I thought somebody had rerun the CI already because it was green. |
Contributor
Author
|
Hmmm, not sure how it works for you as maintainer, but when I look at a PR (e.g. #1454 -- look, I did it!) I see:
Perhaps this doesn't happen if you don't refresh the page or something when merging multiple PRs in a short time frame. |
Contributor
|
Ohh right that makes sense. I read over that part and only looked at the green checkmark 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think #1538 was merged without merging in #1489 and rerunning CI.
@marvinhagemeister, I try to avoid pinging you specifically to merge my PRs, but in this case I'll make an exception. Without this fix I think all future CI runs will fail.