Skip to content

fix(ci): type error in dev_checks fixture#1550

Merged
marvinhagemeister merged 1 commit into
freshframework:mainfrom
deer:fix_type_error
Jul 31, 2023
Merged

fix(ci): type error in dev_checks fixture#1550
marvinhagemeister merged 1 commit into
freshframework:mainfrom
deer:fix_type_error

Conversation

@deer

@deer deer commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

I think #1538 was merged without merging in #1489 and rerunning CI.

@marvinhagemeister, I try to avoid pinging you specifically to merge my PRs, but in this case I'll make an exception. Without this fix I think all future CI runs will fail.

@marvinhagemeister

Copy link
Copy Markdown
Contributor

Whoops, I thought somebody had rerun the CI already because it was green.

@marvinhagemeister marvinhagemeister merged commit 80fece0 into freshframework:main Jul 31, 2023
@deer deer deleted the fix_type_error branch July 31, 2023 13:28
@deer

deer commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Hmmm, not sure how it works for you as maintainer, but when I look at a PR (e.g. #1454 -- look, I did it!) I see:

This branch is out-of-date with the base branch

Perhaps this doesn't happen if you don't refresh the page or something when merging multiple PRs in a short time frame.

@marvinhagemeister

Copy link
Copy Markdown
Contributor

Ohh right that makes sense. I read over that part and only looked at the green checkmark 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants