chore: speed up layout tests#1565
Merged
Merged
Conversation
marvinhagemeister
force-pushed
the
test-speed
branch
from
cd5d98f to
ae3fccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout tests were a bit slow. Noticed that they only check if the server sent HTML is correct and don't need any JS to be executed client side. This means we can skip launching a full
puppeteerprocess and simply assert against the fetched HTML. This brings down the layout test time from a couple of seconds down to<100ms.Wrote a tiny pretty printer that parsers the linkedom document into something for humans to debug when for example a selector isn't found:
Note the charset casing issue is resolved in
preact-render-to-string, just need to cut a new version