Skip to content

www: rewriting "data fetching" code example#1603

Merged
marvinhagemeister merged 7 commits into
freshframework:mainfrom
Asqit:main
Aug 8, 2023
Merged

www: rewriting "data fetching" code example#1603
marvinhagemeister merged 7 commits into
freshframework:mainfrom
Asqit:main

Conversation

@Asqit

@Asqit Asqit commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Creating pull request on issue #1553

Creating pull request on issue #1553

@iuioiua iuioiua left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just needs a bit of tweaking.

Comment thread docs/latest/getting-started/fetching-data.md Outdated
Comment thread docs/latest/getting-started/fetching-data.md Outdated
Comment thread docs/latest/getting-started/fetching-data.md Outdated
Comment thread docs/latest/getting-started/fetching-data.md Outdated
Asqit and others added 5 commits August 7, 2023 14:27
Adding underscore in front of `req` parameter to indicate, that it is not used

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Fixing the comment indicating file location

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Rewriting text, so that it does not sound like tutorial

@iuioiua iuioiua left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few tweaks. Now, LGTM! Thanks for helping out, @Asqit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants