Skip to content

refactor: use useSignal() on the starter counter.tsx - #719

Closed
flemmingmiguel wants to merge 3 commits into
freshframework:mainfrom
flemmingmiguel:init-counter-signals
Closed

refactor: use useSignal() on the starter counter.tsx#719
flemmingmiguel wants to merge 3 commits into
freshframework:mainfrom
flemmingmiguel:init-counter-signals

Conversation

@flemmingmiguel

Copy link
Copy Markdown
Contributor

Having useSignal in the initial example could help adoption of it as the store for islands

@flemmingmiguel
flemmingmiguel marked this pull request as draft September 8, 2022 09:59
@flemmingmiguel
flemmingmiguel marked this pull request as ready for review September 8, 2022 10:03
@lucacasonato

Copy link
Copy Markdown
Member

There is currently a bug in @preact/signals + preact-render-to-string that is resulting in a minor memory leak. I want to make sure this is fixed before we recommend that folks use signals.

@lino-levan

Copy link
Copy Markdown
Contributor

Is this still a bug? I wasn't able to find an issue on either @preact/signals or preact-render-to-string?

The closest thing I see is this issue: preact-render-to-string#191, but the timing doesn't make sense and it's closed anyways.

@flemmingmiguel

flemmingmiguel commented Nov 1, 2022

Copy link
Copy Markdown
Contributor Author

I think that was before the 1.1 of Preact signals, I have the latest versions working with no issues and made a small PR to bump the dependencies of the starter project fresh#873

@iuioiua iuioiua changed the title useSignal on the starter counter.tsx refactor: use useSignal() on the starter counter.tsx Jun 1, 2023
@iuioiua

iuioiua commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

I'll close this PR as it's being superseded by #1234. I'm sorry we didn't get to this earlier, @flemmingmiguel. Either way, thank you very much.

@iuioiua iuioiua closed this Jun 1, 2023
@flemmingmiguel

Copy link
Copy Markdown
Contributor Author

Hey amazing to see the repo moving , was away for the past weeks due to some health issues, happy with the news that the framework is about to speed up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants