refactor: use useSignal() on the starter counter.tsx - #719
refactor: use useSignal() on the starter counter.tsx#719flemmingmiguel wants to merge 3 commits into
useSignal() on the starter counter.tsx#719Conversation
|
There is currently a bug in @preact/signals + preact-render-to-string that is resulting in a minor memory leak. I want to make sure this is fixed before we recommend that folks use signals. |
|
Is this still a bug? I wasn't able to find an issue on either @preact/signals or preact-render-to-string? The closest thing I see is this issue: preact-render-to-string#191, but the timing doesn't make sense and it's closed anyways. |
|
I think that was before the 1.1 of Preact signals, I have the latest versions working with no issues and made a small PR to bump the dependencies of the starter project fresh#873 |
useSignal() on the starter counter.tsx
|
I'll close this PR as it's being superseded by #1234. I'm sorry we didn't get to this earlier, @flemmingmiguel. Either way, thank you very much. |
|
Hey amazing to see the repo moving , was away for the past weeks due to some health issues, happy with the news that the framework is about to speed up |
Having useSignal in the initial example could help adoption of it as the store for islands