Replace Hooks with EventDispatcher Part 3#14853
Replace Hooks with EventDispatcher Part 3#14853nupplaphil merged 51 commits intofriendica:developfrom
Conversation
|
This PR is ready for review before it becomes too big. I replaced the call of Hook::callAll() with the EventDispatcher in 59 places and 27 files. (31 places in 21 files are left) I will fix the code style in a separate commit to make the review easier. |
|
@Art4 Did you test different addons if they're still working with this refactoring? |
|
And moving the content into the |
| * An addon indicates successful login by setting 'authenticated' to non-zero value and returning a user record | ||
| * Addons should never set 'authenticated' except to indicate success - as hooks may be chained | ||
| * and later addons should not interfere with an earlier one that succeeded. |
There was a problem hiding this comment.
marking for "addon policies" ?
No, I didn't, because I'm not familiar with all the addons and I cannot effort the time trying to understand how to run them to test a specific hook. Instead I've written tests for every hook, making sure the new events will map the old hook names and parameter syntax.
Yes, thanks to |
|
@Art4 - Tried to help you (php-cs & merge dev-branch) - but I think I bricked something Please just rebase this branch and drop my 3 commits in case Sorry ^^ |
Art4
force-pushed
the
eventdispatcher-part3
branch
from
7821bf3 to
ea17201
Compare
|
@nupplaphil I merged the |
|
After updating the node with this PR I get an exception and error 500 when visiting the profile page (clicking on the home/house icon) of my user. There's a type error. I'll open an issue... |
|
Issue: #14930 |
3 participants
This is a follow up PR of #14799 and replaces more calls of
Hook::callAll()with the new EventDispatcher.This PR replaces the call of
Hook::callAll()with the EventDispatcher in 59 places and 27 files. (31 places in 21 files are left)