fix: sync package-lock.json with @aws-sdk artifact-storage deps#629
Merged
Conversation
PR #628 added @aws-sdk/client-s3 and @aws-sdk/s3-request-presigner to packages/core for report artifact storage, but the root package-lock.json was never regenerated. The Release workflow's `npm ci` fails with EUSAGE ("Missing: @aws-sdk/s3-request-presigner ... from lock file"), so no 2.0.0-next.105 has published since #628 merged. Regenerated with npm 10 (npm 11 lockfiles break `npm ci` in this repo's CI). Verified: `npm ci --dry-run` now resolves cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
d-klotz
added
release
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
|
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #628 (ADR-010 reporting) added
@aws-sdk/client-s3and@aws-sdk/s3-request-presignertopackages/corefor report artifact storage, but the rootpackage-lock.jsonwas never regenerated. Since #628 merged (2026-07-17), the Release workflow'snpm cifails with:As a result no
2.0.0-next.105has published — the latest published version is stillnext.104(from before #628), so downstream apps can't pick up the reporting work.Fix
Regenerated the root
package-lock.jsonwith npm 10 (npm install --package-lock-only). npm 11 lockfiles breaknpm ciin this repo's CI, so npm 10 was used deliberately.@aws-sdk/@smithyentries, minor transitive version bumps — no dependency removals).Test plan
npm ci --dry-runresolves cleanly (added 2537 packages, no EUSAGE / no "Missing:")2.0.0-next.105on merge🤖 Generated with Claude Code
📦 Published PR as canary version:
2.0.0--canary.629.1a7ad06.0✨ Test out this PR locally via:
npm install @friggframework/admin-scripts@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/core@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/devtools@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/eslint-config@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/prettier-config@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/schemas@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/serverless-plugin@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/test@2.0.0--canary.629.1a7ad06.0 npm install @friggframework/ui@2.0.0--canary.629.1a7ad06.0 # or yarn add @friggframework/admin-scripts@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/core@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/devtools@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/eslint-config@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/prettier-config@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/schemas@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/serverless-plugin@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/test@2.0.0--canary.629.1a7ad06.0 yarn add @friggframework/ui@2.0.0--canary.629.1a7ad06.0Version
Published prerelease version:
v2.0.0-next.105Changelog
🚀 Enhancement
@friggframework/admin-scripts,@friggframework/core,@friggframework/devtools🐛 Bug Fix
@friggframework/admin-scripts,@friggframework/core,@friggframework/devtools,@friggframework/eslint-config,@friggframework/prettier-config,@friggframework/schemas,@friggframework/serverless-plugin,@friggframework/test,@friggframework/uiAuthors: 1