Add generated sources to CI FPC search path#441
Conversation
- Include `source/generated` in cross-compilation builds - Fix CI failures when generated Pascal units are required
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow configuration now includes an additional Free Pascal unit search path Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Suite Timing
Measured on ubuntu-latest x64. |
Benchmark Results386 benchmarks Interpreted: 🟢 10 improved · 🔴 130 regressed · 246 unchanged · avg -2.6% arraybuffer.js — Interp: 🔴 6, 8 unch. · avg -1.9% · Bytecode: 🟢 1, 🔴 10, 3 unch. · avg -4.1%
arrays.js — Interp: 🟢 2, 🔴 2, 15 unch. · avg -0.3% · Bytecode: 🔴 18, 1 unch. · avg -8.8%
async-await.js — Interp: 🔴 1, 5 unch. · avg +0.5% · Bytecode: 🔴 3, 3 unch. · avg -8.5%
base64.js — Interp: 🔴 2, 8 unch. · avg -0.4% · Bytecode: 🔴 10 · avg -8.7%
classes.js — Interp: 🔴 8, 23 unch. · avg -1.3% · Bytecode: 🔴 19, 12 unch. · avg -5.4%
closures.js — Interp: 🔴 5, 6 unch. · avg -3.7% · Bytecode: 🔴 11 · avg -7.1%
collections.js — Interp: 🟢 1, 🔴 1, 10 unch. · avg -0.8% · Bytecode: 🔴 12 · avg -9.0%
csv.js — Interp: 🟢 1, 12 unch. · avg -0.1% · Bytecode: 🔴 13 · avg -7.2%
destructuring.js — Interp: 🔴 4, 18 unch. · avg -0.7% · Bytecode: 🔴 21, 1 unch. · avg -7.2%
fibonacci.js — Interp: 🔴 2, 6 unch. · avg -2.0% · Bytecode: 🔴 8 · avg -9.6%
float16array.js — Interp: 🟢 2, 🔴 10, 20 unch. · avg -1.4% · Bytecode: 🟢 5, 🔴 20, 7 unch. · avg -2.2%
for-of.js — Interp: 🔴 2, 5 unch. · avg -1.4% · Bytecode: 🔴 7 · avg -8.4%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🟢 1, 🔴 11, 30 unch. · avg -1.1% · Bytecode: 🔴 40, 2 unch. · avg -7.6%
json.js — Interp: 🟢 3, 🔴 8, 9 unch. · avg -1.2% · Bytecode: 🔴 17, 3 unch. · avg -8.4%
jsx.jsx — Interp: 🔴 8, 13 unch. · avg -1.8% · Bytecode: 🔴 21 · avg -6.3%
modules.js — Interp: 🔴 1, 8 unch. · avg -0.9% · Bytecode: 🔴 9 · avg -11.3%
numbers.js — Interp: 🔴 1, 10 unch. · avg -1.1% · Bytecode: 🟢 1, 🔴 8, 2 unch. · avg -5.7%
objects.js — Interp: 🔴 4, 3 unch. · avg -3.3% · Bytecode: 🔴 7 · avg -5.9%
promises.js — Interp: 🔴 9, 3 unch. · avg -3.3% · Bytecode: 🔴 6, 6 unch. · avg -3.7%
regexp.js — Interp: 🔴 5, 6 unch. · avg -1.7% · Bytecode: 🔴 11 · avg -8.0%
strings.js — Interp: 🔴 8, 11 unch. · avg -10.6% · Bytecode: 🔴 18, 1 unch. · avg -16.7%
tsv.js — Interp: 9 unch. · avg -0.4% · Bytecode: 🔴 9 · avg -8.3%
typed-arrays.js — Interp: 🔴 19, 3 unch. · avg -4.0% · Bytecode: 🟢 7, 🔴 7, 8 unch. · avg +0.0%
uint8array-encoding.js — Interp: 🔴 13, 5 unch. · avg -15.4% · Bytecode: 🟢 3, 🔴 9, 6 unch. · avg +6.8%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Summary
source/generatedto CI cross-compile FPC unit search paths.Goccia.Temporal.TimeZoneDatacould not resolveGenerated.TimeZoneData.Verification
./build.pas --prod benchmarkrunnerfpc ... -Fu./source/generated ... source/app/GocciaBenchmarkRunner.dpr./build.pas clean testrunner./fixtures/ffi/build.sh && ./build/GocciaTestRunner tests --asi --unsafe-ffi./format.pas --check