Fix cross-build linking for RegExpr units#180
Conversation
- Include generated linker inputs for the RegExpr test build - Fix arm64 macOS linking on cross-regexpr branch
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request adds the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Suite Timing
Measured on ubuntu-latest x64. |
Benchmark Results274 benchmarks Interpreted: 🟢 81 improved · 🔴 139 regressed · 🆕 11 new · 43 unchanged · avg -2.0% arraybuffer.js — Interp: 🟢 1, 🔴 13 · avg -8.6% · Bytecode: 🟢 1, 🔴 13 · avg -7.3%
arrays.js — Interp: 🔴 19 · avg -5.3% · Bytecode: 🔴 19 · avg -7.5%
async-await.js — Interp: 🔴 6 · avg -7.1% · Bytecode: 🔴 6 · avg -8.1%
classes.js — Interp: 🔴 31 · avg -9.7% · Bytecode: 🟢 3, 🔴 11, 17 unch. · avg -1.8%
closures.js — Interp: 🔴 10, 1 unch. · avg -5.1% · Bytecode: 🔴 9, 2 unch. · avg -3.6%
collections.js — Interp: 🟢 1, 🔴 8, 3 unch. · avg -2.7% · Bytecode: 🟢 1, 🔴 10, 1 unch. · avg -4.8%
destructuring.js — Interp: 🟢 6, 🔴 11, 5 unch. · avg -1.1% · Bytecode: 🟢 1, 🔴 10, 11 unch. · avg -2.8%
fibonacci.js — Interp: 🟢 1, 🔴 4, 3 unch. · avg -1.0% · Bytecode: 🔴 8 · avg -7.7%
for-of.js — Interp: 🟢 7 · avg +3.3% · Bytecode: 🟢 4, 🔴 2, 1 unch. · avg +17.2%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🟢 12, 🔴 1, 7 unch. · avg +1.4% · Bytecode: 🔴 16, 4 unch. · avg -5.1%
json.js — Interp: 🟢 4, 🔴 13, 3 unch. · avg -2.5% · Bytecode: 🔴 18, 2 unch. · avg -6.7%
jsx.jsx — Interp: 🟢 8, 🔴 4, 9 unch. · avg +0.4% · Bytecode: 🟢 4, 🔴 4, 13 unch. · avg +0.3%
modules.js — Interp: 🟢 8, 1 unch. · avg +5.3% · Bytecode: 🔴 8, 1 unch. · avg -8.0%
numbers.js — Interp: 🟢 2, 🔴 9 · avg -2.0% · Bytecode: 🔴 9, 2 unch. · avg -6.8%
objects.js — Interp: 🟢 4, 3 unch. · avg +2.6% · Bytecode: 🔴 3, 4 unch. · avg -1.4%
promises.js — Interp: 🟢 6, 🔴 1, 5 unch. · avg +3.4% · Bytecode: 🔴 10, 2 unch. · avg -4.2%
regexp.js — Interp: 🆕 11 · Bytecode: 🆕 11
strings.js — Interp: 🟢 7, 🔴 1, 3 unch. · avg +1.7% · Bytecode: 🔴 11 · avg -8.4%
typed-arrays.js — Interp: 🟢 14, 🔴 8 · avg +2.5% · Bytecode: 🟢 7, 🔴 10, 5 unch. · avg +0.6%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Summary
regexprpackage sources to the cached cross-compilation toolchain so FPC can resolveRegExprduring cross builds.docs/build-system.md.Testing
regexprsources exist before building.Summary by CodeRabbit
Release Notes