Fix CI cross toolchain resource compiler#442
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCI and toolchain workflows updated to ensure Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 70-73: Replace the generic PATH lookup with an explicit check of
the restored toolchain binary: instead of using `command -v fpcres`, test the
file at "$PREFIX/bin/fpcres" (e.g., check existence and executability with a
test like [ -x "$PREFIX/bin/fpcres" ]) and fail with the same error/exit if that
check fails; update the conditional that currently references `command -v
fpcres` to use the "$PREFIX/bin/fpcres" executable check so we verify the
restored cache contains the expected binary.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ce72a0bc-24ae-4ddd-aba8-e717ffc6bbc6
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/toolchain.yml
Contributor
Suite Timing
Measured on ubuntu-latest x64. |
Contributor
Benchmark Results386 benchmarks Interpreted: 🟢 8 improved · 🔴 177 regressed · 201 unchanged · avg -2.3% arraybuffer.js — Interp: 🔴 6, 8 unch. · avg -2.9% · Bytecode: 🟢 5, 9 unch. · avg +1.9%
arrays.js — Interp: 🔴 11, 8 unch. · avg -1.6% · Bytecode: 🟢 2, 17 unch. · avg +1.5%
async-await.js — Interp: 🔴 2, 4 unch. · avg -1.7% · Bytecode: 🟢 2, 4 unch. · avg +2.4%
base64.js — Interp: 🔴 7, 3 unch. · avg -1.5% · Bytecode: 🟢 3, 7 unch. · avg +1.5%
classes.js — Interp: 🔴 13, 18 unch. · avg -2.4% · Bytecode: 🟢 1, 🔴 5, 25 unch. · avg -2.2%
closures.js — Interp: 🔴 8, 3 unch. · avg -4.1% · Bytecode: 🟢 2, 9 unch. · avg +1.1%
collections.js — Interp: 🔴 1, 11 unch. · avg -1.4% · Bytecode: 🟢 2, 10 unch. · avg +2.3%
csv.js — Interp: 🟢 1, 12 unch. · avg -0.2% · Bytecode: 🟢 2, 11 unch. · avg +1.2%
destructuring.js — Interp: 🔴 5, 17 unch. · avg -1.5% · Bytecode: 🟢 8, 🔴 1, 13 unch. · avg +2.0%
fibonacci.js — Interp: 🔴 5, 3 unch. · avg -3.0% · Bytecode: 🟢 1, 7 unch. · avg +1.0%
float16array.js — Interp: 🟢 1, 🔴 17, 14 unch. · avg -1.9% · Bytecode: 🟢 6, 🔴 4, 22 unch. · avg +0.1%
for-of.js — Interp: 🔴 3, 4 unch. · avg -2.0% · Bytecode: 🟢 2, 5 unch. · avg +2.9%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🔴 20, 22 unch. · avg -2.6% · Bytecode: 🟢 13, 🔴 3, 26 unch. · avg +1.3%
json.js — Interp: 🔴 11, 9 unch. · avg -3.1% · Bytecode: 🟢 1, 🔴 9, 10 unch. · avg -1.8%
jsx.jsx — Interp: 🟢 2, 🔴 3, 16 unch. · avg -0.1% · Bytecode: 🟢 2, 🔴 1, 18 unch. · avg -0.0%
modules.js — Interp: 🔴 2, 7 unch. · avg -1.9% · Bytecode: 🟢 4, 5 unch. · avg +1.8%
numbers.js — Interp: 🔴 8, 3 unch. · avg -3.7% · Bytecode: 🟢 7, 🔴 1, 3 unch. · avg +2.4%
objects.js — Interp: 7 unch. · avg -0.6% · Bytecode: 🟢 1, 🔴 3, 3 unch. · avg -2.1%
promises.js — Interp: 🔴 7, 5 unch. · avg -2.4% · Bytecode: 12 unch. · avg +1.1%
regexp.js — Interp: 🔴 5, 6 unch. · avg -1.3% · Bytecode: 🔴 6, 5 unch. · avg -3.0%
strings.js — Interp: 🔴 9, 10 unch. · avg -12.1% · Bytecode: 🟢 5, 🔴 2, 12 unch. · avg +1.4%
tsv.js — Interp: 🔴 3, 6 unch. · avg -1.6% · Bytecode: 🟢 1, 🔴 1, 7 unch. · avg +0.1%
typed-arrays.js — Interp: 🔴 21, 1 unch. · avg -3.6% · Bytecode: 🟢 4, 🔴 11, 7 unch. · avg -2.4%
uint8array-encoding.js — Interp: 🟢 4, 🔴 10, 4 unch. · avg +5.5% · Bytecode: 🟢 3, 🔴 5, 10 unch. · avg +4.8%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
This fixes the CI failure where FPC cannot find fpcres while linking the generated timezone resource.