dgb: donation_consensus validation layer (Scrypt-only) — oracle-rebaselined - #125
Merged
Conversation
Namespace-only port of the consensus donation-validation surface from src/impl/ltc/donation_consensus.hpp into dgb::consensus. Stacks on the share_check/share_tracker pillars (now on master via #121). Script selection defers to dgb::PoolConfig::get_donation_script: v35 (share_version<36): forrestv P2PK 67B [4104ffd0...] (DGB oracle) v36 (>=36): combined P2SH 1-of-2 (forrestv + maintainer) SOURCE OF TRUTH is the DGB oracle frstrtr/p2pool-dgb-scrypt (switch-oracle, Option B, landed #122), IDENTIFIER 4B62545B1A631AFE — NOT a uniform v35 script and NOT the reverted farsider350 2-of-3 P2MS. validate_donation_output / validate_coinbase_total / build_expected_payouts remain byte-parity with the LTC reference logic; ShareTracker::get_expected_payouts signature is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DGB Phase B — donation_consensus port (re-landed off #116)
Namespace-only port of the consensus donation-validation surface from
src/impl/ltc/donation_consensus.hppintodgb::consensus. Recovered from the now-closed #116 chain and rebased onto current master (carries #121 share_check/share_tracker + #122 switch-oracle).Oracle re-baseline (per integrator directive)
Donation script selection defers to
dgb::PoolConfig::get_donation_script(config_pool.hpp, on master via #122):4104ffd0...— DGB oracle frstrtr/p2pool-dgb-scrypt, IDENTIFIER4B62545B1A631AFEByte-verified the v35 constant in master config:
0x41 0x04 0xff 0xd0 ... 0xac= script hex4104ffd0.... This is NOT a uniform v35 script and NOT the reverted farsider350 2-of-3 P2MS — stale comments referencing P2MS corrected in this commit.Scope / parity
validate_donation_output/validate_coinbase_total/build_expected_payoutsbyte-parity with LTC reference logicShareTracker::get_expected_payoutssignature identicalGPG-signed. HOLD merge — integrator merges on operator approval.