dgb(test): pin pool/share-layer params to p2pool-dgb-scrypt oracle - #161
Merged
Conversation
Phase B conformance: audited the DGB pool/share constant + tracker score-period layer against the frstrtr/p2pool-dgb-scrypt oracle (networks/digibyte.py + bitcoin/networks/digibyte.py) and confirmed full conformance. Lock the previously-unguarded params against drift in share_test.cpp (target already in both build.yml allowlists): SPREAD=24, TARGET_LOOKBEHIND=100, REAL_CHAIN_LENGTH=2880, BLOCK_MAX_SIZE=32000000, BLOCK_MAX_WEIGHT=128000000, CoinParams::BLOCK_PERIOD=75 (PARENT.BLOCK_PERIOD, tracker score() denom), MAX_TARGET = 2**256//2**20 - 1 = 2^236-1. Test-only, single-coin, strictly inside src/impl/dgb/test/. No shared base / bitcoin_family / src/core touched. dgb_share_test 6/6 PASS.
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase B pool/share conformance slice.
Audit: diffed the DGB pool/share constant + tracker score-period layer against the
frstrtr/p2pool-dgb-scryptoracle (networks/digibyte.py+bitcoin/networks/digibyte.py) as ground truth. Result: full conformance — no production code change needed.Change: lock the previously-unguarded params in
share_test.cpp(drift guard). NewOraclePoolShareLayertest pins:Scope: test-only, single-coin, strictly inside
src/impl/dgb/test/. Nobitcoin_family//src/core// CMake / build.yml touch (targetdgb_share_testalready in both allowlists). Local: build EXIT=0, dgb_share_test 6/6 PASS.HOLD merge — integrator merges on operator approval.