nmc(v37): classify always-fire dual-path as BUCKET-1 (do not converge to core SSOT) - #500
Merged
Merged
Conversation
… to core SSOT) The NMC won-aux-block dispatcher fires the namecoind submitauxblock RPC leg ALWAYS, even after a P2P win -- unlike core::broadcast_block_with_fallback, which short-circuits on P2P success to avoid a double-broadcast. For a merge- mined aux block the always-fire RPC leg is a per-coin consensus-path invariant (duplicate aux submission is a harmless daemon rejection, never a silent drop). Add an in-file v37 3-bucket classification banner marking this as BUCKET-1 (per-coin isolation, KEEP) so the v37 multichain migration -- or any agent converging coins onto the core broadcast SSOT -- does not collapse NMC onto the short-circuit SSOT and silently drop the aux leg. Comment-only; behaviour is already KAT-locked by NmcAuxBlockBroadcast.DualPathAlwaysFiresFallback. No consensus-value, build, or runtime change. nmc-fenced (src/impl/nmc only).
frstrtr
added a commit
that referenced
this pull request
Jun 26, 2026
…RPC) (#530) The won-block path called submit_block_with_fallback, whose P2P-primary policy treats a cmpctblock announce-success as reaching the network and so short-circuits the submitblock RPC. But an announce does NOT connect the tip: under compact-block relay the daemon requests the body via getblocktxn, which the c2pool broadcaster does not serve, so the block never ConnectBlock()s and the subsidy is silently lost (G3b leg-(b) blocker). Add a BTC-lane-fenced broadcast_block_for_connect / submit_block_for_connect that fires the submitblock RPC UNCONDITIONALLY (connect-authoritative), keeping the P2P relay for best-effort fast propagation, and wire the stratum won-block path to it. The cross-coin core::broadcast_block_with_fallback contract is untouched (the always-fire convergence stays HOLD per #500/#498); only the BTC connect path opts in. New block_broadcast_connect_test.cpp rides the allowlisted btc_share_test (no NOT_BUILT risk) and pins the always-fire invariant plus a side-by-side contrast lock that the fallback policy still short-circuits. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an in-file v37 3-bucket classification banner to
nmc::coin::broadcast_won_aux_blockmarking its always-fire submitauxblock RPC leg as BUCKET-1 (per-coin isolation invariant -- KEEP).Why
Post-#498, BTC delegates its won-block broadcast to
core::broadcast_block_with_fallback, which short-circuits on a P2P win (if (p2p_ok) return true;) to avoid double-broadcast. NMC is merge-mined: the external namecoindsubmitauxblockRPC leg must fire ALWAYS, even after a P2P win (a duplicate aux submission is a harmless daemon rejection, never a silent drop).Naively converging NMC onto the core short-circuit SSOT during the v37 multichain migration would drop the always-fire aux leg -- a consensus-path regression. This banner makes the convergence verdict executable in-file so v37 tooling (or any agent doing cross-coin broadcast convergence) does not collapse NMC onto the SSOT.
Safety
src/impl/nmc/coin/block_broadcast.hpponly); pulls no btc/dgb symbol.NmcAuxBlockBroadcast.DualPathAlwaysFiresFallback;nmc_block_broadcast_test7/7 green on this branch.Held for integrator review + operator tap. I do not self-merge.