dash(s8): wire version-gate into a real accept entry (close enforcement hole) - #568
Merged
Conversation
…ose enforcement hole) dash::verify_version_transition was KAT-proven in isolation but had ZERO src/ consumers -- the v36 obsolescence (95% weighted) + successor (60% weighted) version-boundary guards never ran on any admission path. Add dash::verify_share, the combined accept entry mirroring btc verify_share: Phase 1 share_init_verify (X11 PoW/hash_link/merkle/target, thread-pool offloadable via verify_init=false) then Phase 2 verify_version_transition (the now-wired chain-context gate). dashd-RPC submitblock fallback is untouched -- this gates SHARE admission, not block submission. Retarget the 7-case version-wiring KAT to drive the gate through verify_share (the wired path), not the orphan primitive, and add an init-composition case proving Phase 1 rejects a structurally invalid share before the gate is consulted. 7/7 wired cases + 51/51 full test_dash_conformance green on Linux x86_64. Bucket-2 structural standardization: same compose shape as btc verify_share, so the v37 unification is a clean migration rather than a per-coin v36 dialect. dash-fenced (src/impl/dash/ + test only), additive, no shared-layer or cross-coin touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dash::verify_version_transition(the v36 obsolescence + successor version-boundary gate) was KAT-proven in isolation but had ZERO src/ consumers — it never ran on any admission path. This addsdash::verify_share, the combined accept entry (mirroringbtc::verify_share), which composes:share_init_verify(X11 PoW / hash_link / merkle / target; thread-pool-offloadable viaverify_init=false, cf. dgb node.cpp two-phase)verify_version_transition, now a wired chain-context gateVerify bar (per integrator UID2882)
verify_share, plus a 7th proving Phase-1 init rejects a structurally invalid share before the gate. Rejects obsolete (v<36 @95% weighted) + sub-floor (upgrade without 60% weighted successor) shares. Not an 85% byte-match.test_dash_conformancegreen on Linux x86_64.Scope
dash-fenced (
src/impl/dash/+ test only), additive, no shared-layer or cross-coin touch → single-coin isolation invariant. Bucket-2 structural standardization (same compose shape as btc) for a clean v37 migration.No self-merge — held for integrator verify → operator tap.