test(dash/s8): stratum extranonce coinb1/coinb2 split contract KAT#633
Merged
Conversation
This was referenced Jul 4, 2026
Fenced KAT (test/ + build.yml allowlist only) binding the REAL landed producer dash::coinbase::split_coinb() -- the mining.subscribe/notify wire split coinb1 || <extranonce2> || coinb2 that the get_work slot KAT and notify-roundtrip KAT do not cover. Pins: the split leaves a gap of exactly EXTRANONCE2_SIZE (==8) between coinb1 and coinb2 (== oracle stratum.py COINBASE_NONCE_LENGTH advertised in mining.subscribe); coinb1/coinb2 are the exact bytes around the slot; reassembling coinb1||extranonce2||coinb2 reproduces the EXACT coinbase sha256d the slot/notify KATs golden-anchor; distinct extranonce2 are injective; a wrong-width extranonce2 breaks the coinbase length; bad offset throws. Goldens = independent Python hashlib sha256d (non-circular). Non-consensus, socket-free, node-free. 6/6.
frstrtr
force-pushed
the
dash/s8-stratum-extranonce-split
branch
from
4747b69 to
d839d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fenced (test/ + build.yml allowlist only), non-consensus, merge-gated — no self-merge.
Binds the REAL landed producer
dash::coinbase::split_coinb()— the mining.subscribe/mining.notify wire splitcoinb1 || <extranonce2> || coinb2— which the get_work slot KAT (test_dash_stratum_binding, #630) and the notify-roundtrip KAT (test_dash_stratum_notify_roundtrip, #631) do not cover. This is the next stratum-binding suite leaf integrator named (extranonce).Pins:
EXTRANONCE2_SIZE==8 between coinb1/coinb2 == oraclestratum.pyCOINBASE_NONCE_LENGTH advertised in mining.subscribe;Oracle: frstrtr/p2pool-dash @9a0a609 — stratum.py rpc_subscribe extranonce2_size, work.py get_work coinb1/coinb2. Goldens = independent Python hashlib sha256d (non-circular; identical to the notify leaf coinbase anchors).
Base master @ff20c365. Local: 6/6 non-hollow (ctest from build/, out of 6). GPG-signed @4747b69f. Merge-gated on FULL green rollup + operator tap.