DASH S8 stratum mining.submit reassembly KAT — close subscribe→notify→submit triangle#634
Merged
Merged
Conversation
frstrtr
force-pushed
the
dash/s8-stratum-submit-reassembly
branch
from
5fd43f1 to
ab7d0f2
Compare
frstrtr
force-pushed
the
dash/s8-stratum-submit-reassembly
branch
from
ab7d0f2 to
d4ccd36
Compare
…submit triangle Bind the REAL landed producers split_coinb() + merkle_branches_raw() to prove a miner submit (extranonce2, ntime, nonce) reconstructs the EXACT 80-byte block header whose sha256d is the share hash. Reassembled coinbase cross-checks the Python sha256d anchors; extranonce2/ntime/nonce each shown to bind injectively into the share. Fenced test/ + build.yml only, non-consensus, socket/node-free.
…t allowlist The second (-fsanitize=address,undefined) --target allowlist in build.yml omitted test_dash_stratum_submit_reassembly, so the ASan job never built the binary while ctest still had the 7 DashStratumSubmitReassembly cases registered from configure -> reported (Not Run) -> exit 8 -> RED. The non-ASan Linux/macOS/Windows builds pass because their allowlist (line 105) already includes it. Build-glue only; no source or sanitizer semantics change.
frstrtr
force-pushed
the
dash/s8-stratum-submit-reassembly
branch
from
839036e to
9dddc71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the third and final side of the stratum wire contract (subscribe→notify→submit), after #630 (get_work slot), #631 (notify merkle fold), #633 (subscribe coinb1/coinb2 split).
What it binds. Given a miner submit
(extranonce2, ntime, nonce), the KAT reconstructs the EXACT 80-byte block header whose sha256d is the share hash, using the REAL landed producersdash::coinbase::split_coinb()anddash::coinbase::merkle_branches_raw()(the exact code mining.subscribe/mining.notify ship). The miner-side reassembly (coinb1||en2||coinb2), merkle fold (index 0), and header assembly are mirrored locally (the miner is cpuminer, not our code — same rationale as #631);handle_submit→compute_share_difficulty(stratum_server.cpp:877) walks the identical reconstruction.Non-circular anchoring.
GOLD_ROOT_*.Fencing. test/ + build.yml allowlist only. Non-consensus, socket-free, node-free — pure synthetic CoinbaseLayout, no live node/RPC/P2P.
Local result:
ctest -R DashStratumSubmitReassembly→ 7/7 (tests #925–931), non-hollow from build/. Merge-gated on full green + tap; no self-merge.Oracle: frstrtr/p2pool-dash @9a0a609 (work.py:474, dash/data.py block_header_type, dash/stratum.py rpc_submit).