Phase 5.8 M3: land regtest AuxPoW KAT (h=20) into master (test-only regression guard) - #64
Merged
Merged
Conversation
Add a known-answer vector built from a real AuxPoW block mined at height 20 on the operator-ratified self-hosted regtest/testnet4alpha seed and accepted by dogecoind. The 217-byte CAuxPow proof, serialized by Dogecoin Core itself, is fed straight through the c2pool CAuxPow Unserialize path (the one parse_aux_header drives) and asserted field-for-field: parent coinbase with the fabe6d6d merged-mining commitment, CMerkleTx tail, empty single-chain merkle links, and the parent 80-byte header. Consumes exactly 217 bytes. Also fix the hex_to_bytes helper char literals (the 0/9/a/f/A/F comparisons were missing single quotes, so the prior KAT draft did not compile). test_doge_chain 37/37 green; full ctest 590/590 green (Linux x86_64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only regression-guard backport of the #59 AuxPoW KAT
Lands the Phase 5.8 M3 known-answer vector + test into
masterso it runs in CI on every future change. The KAT was authored on the now-merged-awayc2pool-m3worktree (a6693c2d); without this backport it provides zero ongoing regression protection. For a V36 hard gate (Phase 5.8 AuxPoW), the proof must be replayable from master history.What this is
Cherry-pick of
a6693c2d— a single test file change:test/test_doge_chain.cpp(+186)AuxPowKnownAnswerTest.RegtestH20CAuxPowDecodesRealProof— feeds the fixture through the c2poolCAuxPowUnserializepath (the oneparse_aux_header()drives), asserts field-for-field (parent coinbasefabe6d6dmerged-mining commitment,CMerkleTxtail, empty single-chain merkle links, parent 80-byte header), and confirms exact consumption (cursor_size() == 0)test_doge_chainwiringWhat this is NOT
No source or behavior change. No new production code paths. Single-coin tree (
src/impl/doge/consumers + the doge test only) — no cross-coin entanglement, stays inside isolation rules.Verification (this branch, clean off
origin/master6528ece)test_doge_chain: 37/37 green, includingRegtestH20CAuxPowDecodesRealProofPer-coin DOGE smoke gate suffices. Holding for operator push approval before merge.