-
Notifications
You must be signed in to change notification settings - Fork 124
Closed
Description
Just starting a discussion on some remaining issues for dotnet core support, please feel free to chime in if you have any insight on the best approach.
- There is an outstanding assembly resolution problem with checker.GetProjectOptionsFromScript(file, code), similar to #535 and #567, that may need to be fixed before pushing an official netcore version to NuGet. Tests are currently avoiding it (netcore only) by not using it (using command line args instead):
#if TODO_REWORK_ASSEMBLY_LOAD
let dllName = Path.ChangeExtension(file, ".dll")
let projName = Path.ChangeExtension(file, ".fsproj")
let args = mkProjectCommandLineArgs (dllName, [file])
let projectOptions = checker.GetProjectOptionsFromCommandLineArgs (projName, args)
#else
// ===> this does not work properly under DotNet Core:
let projectOptions = checker.GetProjectOptionsFromScript(file, input) |> Async.RunSynchronously
#endif
Metadata
Metadata
Assignees
Labels
No labels