Skip to content

Conversation

@7sharp9
Copy link
Member

@7sharp9 7sharp9 commented Feb 11, 2015

This unifies tooltip/completion/parameter completion so each one can be
queried as symbols. The symbol information is used by the F# language
binding to display extra information and render tooltips and
completions semantically.

This unifies tooltip/completion/parameter completion so each one can be
queried as symbols.  The symbol information is used by the F# language
binding to display extra information and render tooltips and
completions semantically.
@dsyme
Copy link
Contributor

dsyme commented Feb 13, 2015

Hi @7sharp9 - It looks good - could you add some tests?

GetMethodsAsSymbols should return all overloads of a method as
FSharpSymbolUse
@7sharp9
Copy link
Member Author

7sharp9 commented Feb 16, 2015

@dsyme Ok, added test for this similar to GetMethods test in EditorTests.fs

@7sharp9
Copy link
Member Author

7sharp9 commented Feb 16, 2015

Not sure whats up with Travis, tests seem fine with AppVeyor though.

fsgit added a commit that referenced this pull request Feb 17, 2015
@fsgit fsgit merged commit 17447cd into fsharp:master Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants