Skip to content

Conversation

@ncave
Copy link
Contributor

@ncave ncave commented Jun 20, 2016

A quick hack to make script parsing work.

@dsyme
Copy link
Contributor

dsyme commented Jun 20, 2016

@ncave I'm OK with this as a temporary thing, but perhaps you could submit an issue and alignment PR to Microsoft/visualfsharp too? Ultimately that's the repo where the Microsoft-supported .NET Core packages for F# will be published from.

Where possible we should include @KevinRansom in this toodiscussion, since we need to be on a path to convergence in the specification of the .NET Core F# scripting programming model.

@dsyme
Copy link
Contributor

dsyme commented Jun 20, 2016

@ncave Also, is there any specific reason why you chose this list of types? Is it the set needed to support FSharp.Core?

@dsyme dsyme merged commit f12c0e8 into fsharp:master Jun 20, 2016
@ncave
Copy link
Contributor Author

ncave commented Jun 20, 2016

@dsyme It's an ad-hoc set of dependencies used to pass most of the script tests in the test suite.
I'll open an issue in Microsoft/visualfsharp to possibly get a better solution by @KevinRansom.

@dsyme
Copy link
Contributor

dsyme commented Jun 21, 2016

Thanks, please link the issue here

FWIW I think we should also be referencing these assemblies (e.g. System.IO) in .NET Framework F# Interactive scripting. There have been cases that I've had to reference System.IO manually when referencing PCL or .NET Standard components from F# Interactive. It would be better if we just auto-referenced all the relevant .NET Framework facade assemblies that cover the new-style PCL/.NETStandard surface area for "mscorlib", "System" and "System.Core"

@ncave
Copy link
Contributor Author

ncave commented Jun 21, 2016

Added an issue in Microsoft/visualfsharp: #1272

@ncave ncave deleted the netcore branch June 21, 2016 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants