Add symbol creation for an operator with a constraint #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025 |
Contributor
|
thanks, shouldn't this go to VF# first / too ? |
Member
Author
|
@goswinr It can, but I've always committed here first. |
KevinRansom
pushed a commit
to dotnet/fsharp
that referenced
this pull request
Mar 9, 2019
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to:
Item.ImplicitOp(_, { contents = Some(TraitConstraintSln.FSMethSln(_, vref, _)) })
Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use.
An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025
Corresponding PR at FCS: fsharp/fsharp-compiler-docs#896
Collaborator
|
Closing this because the associated VF# issue was merged. |
baronfel
pushed a commit
to baronfel/FSharp.Compiler.Service
that referenced
this pull request
Mar 22, 2019
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to:
Item.ImplicitOp(_, { contents = Some(TraitConstraintSln.FSMethSln(_, vref, _)) })
Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use.
An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025
Corresponding PR at FCS: fsharp#896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to:
Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use.