GenericTypesNames: fix some false negative and add unit test #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@janus please split this in 2 commits, one (first) that adds the unit test (which should have a red CI) and another one with the fix. When pushing these 2 commits, use |
janus
force-pushed
the
UpdateGenericTypeNames-squashed
branch
from
eab3493 to
41787e7
Compare
Contributor
Author
Done. Thanks. |
Collaborator
|
@janus please reopen this PR. (It got closed automatically when you used the gitPush1by1 command.) |
Contributor
Author
Done. |
It seems the rule is hardcoding the function isPascalCase, which means that it's not really looking at the configuration of the rule. This theory will be demonstrated if this commit's CI status is red.
This reverts commit 8ed70d2.
janus
force-pushed
the
UpdateGenericTypeNames-squashed
branch
from
ae3c045 to
2546dc8
Compare
knocte
force-pushed
the
UpdateGenericTypeNames-squashed
branch
from
86aac3d to
53ff48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #551.