Skip to content

RedundantNewKeyword: fix failing unit test #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2022
Merged

RedundantNewKeyword: fix failing unit test #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ec0f7a
RedundantNewKeyword: add more unit test
janus Jun 28, 2022
edb3d87
RedundantNewKeyword: fix failing unit test
janus Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/FSharpLint.Core/Rules/Conventions/RedundantNewKeyword.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ let private doesNotImplementIDisposable (checkFile:FSharpCheckFileResults) (iden
ctor.DeclaringEntity
|> Option.exists (fun ctorForType ->
Seq.forall (implementsIDisposable >> not) ctorForType.AllInterfaces)
| Some(_) | None -> false
| Some symbol when (symbol.Symbol :? FSharpEntity) ->
let ctor = symbol.Symbol :?> FSharpEntity
Seq.forall (implementsIDisposable >> not) ctor.AllInterfaces
| Some _ -> false
| None -> true

let private generateFix (text:string) range = lazy(
ExpressionUtilities.tryFindTextOfRange range text
Expand All @@ -38,8 +42,9 @@ let private generateFix (text:string) range = lazy(


let runner args =
match (args.AstNode, args.CheckInfo) with
| (AstNode.Expression(SynExpr.New(_, SynType.LongIdent(identifier), _, range)), Some checkInfo) ->
match args.AstNode, args.CheckInfo with
| AstNode.Expression(SynExpr.New(_, SynType.LongIdent(identifier), _, range)), Some checkInfo
| AstNode.Expression(SynExpr.New(_, SynType.App(SynType.LongIdent(identifier), _, _, _, _, _, _), _, range)), Some checkInfo ->
{ Range = range
Message = Resources.GetString("RulesRedundantNewKeyword")
SuggestedFix = Some (generateFix args.FileContent range)
Expand Down
29 changes: 28 additions & 1 deletion tests/FSharpLint.Core.Tests/Rules/Conventions/RedundantNewKeyword.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,31 @@ module Program
let _ = System.Version()"""

this.Parse source
Assert.AreEqual(expected, this.ApplyQuickFix source)
Assert.AreEqual(expected, this.ApplyQuickFix source)

[<Test>]
member this.``new keyword is not required (1).``() =
this.Parse("""
module Program
let foo =
new System.Collections.Generic.Dictionary<string, string>() |> ignore""")

Assert.IsTrue this.ErrorsExist

[<Test>]
member this.``new keyword is not required (2).``() =
this.Parse("""
module Program
let foo =
new Guid() |> ignore""")

Assert.IsTrue this.ErrorsExist

[<Test>]
member this.``new keyword is not required (3).``() =
this.Parse("""
module Program
let foo =
new Int32() |> ignore""")

Assert.IsTrue this.ErrorsExist