Skip to content

Fix ParameterNames rule #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged

Fix ParameterNames rule #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78304fc
Tests(ParameterNames): fix test
webwarrior-ws Aug 6, 2025
3aeff5d
Tests(ParameterNames): add test for module members
webwarrior-ws Aug 6, 2025
148445c
ParameterNames: fix rule
webwarrior-ws Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FSharpLint.Core/Rules/Conventions/Naming/ParameterNames.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ let private getIdentifiers (args:AstNodeRuleParams) =
| AstNode.Binding(SynBinding(access, _, _, _, attributes, _, valData, pattern, _, _, _, _, _)) ->
if not (isLiteral attributes) then
match identifierTypeFromValData valData with
| Value | Function ->
| Function ->
let accessControlLevel = getAccessControlLevel args.SyntaxArray args.NodeIndex
getPatternIdents accessControlLevel (getValueOrFunctionIdents args.CheckInfo) true pattern
| Member | Property ->
Expand Down
15 changes: 13 additions & 2 deletions tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/ParameterNames.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,13 @@ let result = extractInt singleCaseDU
let source = """
module Program

let __foo_bar = 0
let baz __foo_bar = 0
"""

let expected = """
module Program

let __foobar = 0
let baz __foobar = 0
"""

this.Parse source
Expand Down Expand Up @@ -114,3 +114,14 @@ let foo ((x, y) as bar_coord) = bar_coord
"""

Assert.IsTrue this.ErrorsExist

[<Test>]
member this.``Module members should not cause errors as they are not parameters``() =
this.Parse """
module BitLaunch =
module Regions =
let Bucharest = "Bucharest"
let Amsterdam someArg = "Amsterdam"
"""

Assert.IsFalse this.ErrorsExist
Loading