copy_local: true has no effect on netstandard projects

[aggieben]

Description

Dependencies are not copied to the output directory of a project targeting netstandard2.x (but they are for net4x).

Repro steps

Please provide the steps required to reproduce the problem

1. dotnet new -i "MiniScaffold::*"

2. dotnet new mini-scaffold

3. After restore/build completes, check {proj}\bin\Debug\net461 and see dependencies copied. Check {proj}\bin\Debug\netstandard2.1 and see no dependencies copied.

If possible then please create a git repository with a repro sample or attach a zip to the issue.

Expected behavior

Expect copy local behavior to match paket directive. This is rather important for building certain things, like type providers. I also think this is the root cause of BenchmarkDotNet#1392.

Actual behavior

The paket directive seems to not matter. See also: #3645, #3352, #3154, #3186.

Known workarounds

None? Using PackageReference instead of paket, I guess

[aggieben]

I think this block in src/Paket.Core/embedded/Paket.Restore.targets is the key bit:

    <ItemGroup Condition="($(DesignTimeBuild) != true OR '$(PaketPropsLoaded)' != 'true') AND '@(PaketReferencesFileLines)' != '' " >
      <PaketReferencesFileLinesInfo Include="@(PaketReferencesFileLines)" >
        <Splits>$([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',').Length)</Splits>
        <PackageName>$([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',')[0])</PackageName>
        <PackageVersion>$([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',')[1])</PackageVersion>
        <AllPrivateAssets>$([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',')[4])</AllPrivateAssets>
        <CopyLocal Condition="'%(PaketReferencesFileLinesInfo.Splits)' == '6'">$([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',')[5])</CopyLocal>
      </PaketReferencesFileLinesInfo>
      <PackageReference Include="%(PaketReferencesFileLinesInfo.PackageName)">
        <Version>%(PaketReferencesFileLinesInfo.PackageVersion)</Version>
        <PrivateAssets Condition=" ('%(PaketReferencesFileLinesInfo.AllPrivateAssets)' == 'true') Or ('$(PackAsTool)' == 'true') ">All</PrivateAssets>
        <ExcludeAssets Condition=" '%(PaketReferencesFileLinesInfo.Splits)' == '6' And %(PaketReferencesFileLinesInfo.CopyLocal) == 'false'">runtime</ExcludeAssets>
        <ExcludeAssets Condition=" '%(PaketReferencesFileLinesInfo.Splits)' != '6' And %(PaketReferencesFileLinesInfo.AllPrivateAssets) == 'exclude'">runtime</ExcludeAssets>
        <Publish Condition=" '$(PackAsTool)' == 'true' ">true</Publish>
        <AllowExplicitVersion>true</AllowExplicitVersion>
      </PackageReference>
    </ItemGroup>

It looks to me like setting PrivateAssets to All is not the correct behavior in the case that copy_local = true. This value is coming from the resolved references file FSharp.Data.GraphQL.Benchmarks.fsproj.netcoreapp2.1.paket.resolved generated by paket. In my case, the first line looks like this:

FSharp.Core,4.7,Direct,Main,true,true

The AllPrivateAssets property above is set to the value of the 5th field: FSharp.Core,4.7,Direct,Main,true,true

So I think this indicates that paket is setting this property to true in some cases when it should probably be false.

[aggieben]

🦗

[samangh]

I'm also running into this issue, with Paket version 5.247.4