don't remove nodes that correspond to packed projects from nuspecs - #3983
Merged
Conversation
Contributor
Author
|
The CI issues seem to be because a roslyn feed is missing? |
Contributor
Author
|
This test works for me when I manually build and do all the orchestration things the FAKE script would do, since there's a dependency problem there with the roslyn bits it seems. |
baronfel
marked this pull request as ready for review
June 9, 2021 15:29
baronfel
force-pushed
the
fix-project-refs
branch
from
June 9, 2021 15:30
b98e4ae to
a0656c3
Compare
Contributor
Author
|
I believe that the single test failure here is unrelated to my change, as it's checking for Microsoft.CSharp on the v3 endpoint, which I didn't change at all here. Any thoughts on the implementation? |
Member
|
thanks |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on fsprojects/FsLexYacc#145 I discovered that
paket fix-nuspecswas removing package references from the nuspec that corresponded to project references, but only when those project references correspond to a packagereference that paket is tracking.This happens for fslex because it has a project ref on the fslexyacc.runtime project to run the generated lexers and parsers it contains, but it also needs to generate those parsers using the fslexyacc meta-package, which includes a transitive reference to fslexyacc.runtime. This transitive is what caused the removals.
I'll add a test to this as time permits.