Fix CancellationToken parameter ordering and name collision in v3 OperationCompiler#341
Draft
Copilot wants to merge 2 commits intorepo-assist/feat-cancellationtoken-issue-212-2026-03-23-448c1cde90ec7d95from
Conversation
…CT name Co-authored-by: sergey-tihon <1197905+sergey-tihon@users.noreply.github.com> Agent-Logs-Url: https://github.com/fsprojects/SwaggerProvider/sessions/b0c519de-0186-40ca-8174-42ed67a5316a
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on CancellationToken support in OpenApiClientProvider methods
Fix CancellationToken parameter ordering and name collision in v3 OperationCompiler
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the CT overload generation: CT was appended after optional parameters (invalid in .NET — required params must precede optional), and the CT parameter name was always
cancellationTokenwith no collision check against generated OpenAPI parameter names.Changes
Parameter ordering: Split parameter building into two passes (required, then optional) with the used-name set threaded between them. CT is now inserted at
ctArgIndex = requiredParamCount, giving the signature:(required...) → CT → (optional...).Name uniqueness: Collect all generated parameter names into a set before creating the CT param; fall back to
cancellationToken1,cancellationToken2, etc. on collision.invokeCodeextraction: CT is now extracted byList.item ctArgIndex allArgs(index captured during parameter building) rather than by peeling off the last argument, which broke under the new ordering.Before / After signature example
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.