Fix index-without-dot followed by application arguments#3259
Merged
nojaf merged 2 commits intofsprojects:mainfrom Mar 9, 2026
Merged
Fix index-without-dot followed by application arguments#3259nojaf merged 2 commits intofsprojects:mainfrom
nojaf merged 2 commits intofsprojects:mainfrom
Conversation
The App active pattern flattened through IndexWithoutDot expressions, losing the no-space indexing semantics. This caused inconsistent formatting: `prepConfigs[1] host` worked but `prepConfigs[1] host port` produced `prepConfigs [ 1 ] host port`. Stop flattening in the App active pattern when hitting IndexWithoutDot, remove the ExprNestedIndexWithoutDotNode workaround, and handle IndexWithoutDot as a function expression in the code printer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The App active pattern flattened through IndexWithoutDot expressions, losing the no-space indexing semantics. This caused inconsistent formatting:
prepConfigs[1] hostworked butprepConfigs[1] host portproducedprepConfigs [ 1 ] host port.Stop flattening in the App active pattern when hitting IndexWithoutDot, remove the ExprNestedIndexWithoutDotNode workaround, and handle IndexWithoutDot as a function expression in the code printer.