Fix LocalFileSystem directory symlink removal#2074
Merged
martindurant merged 1 commit intoJul 14, 2026
Conversation
LocalFileSystem.rm() treated symlinks to directories as directories because isdir() follows links. This rejected non-recursive removal and routed recursive removal through shutil.rmtree(). Unlink directory symlinks as files so their targets remain untouched, and cover both recursive modes in the linked-directory test. Fixes fsspec#1299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalFileSystem.rm()treated directory symlinks as directories becauseisdir()follows links, so removing a link requiredrecursive=Trueand then routed it throughrmtree(). Excluding symlinks from the directory branch unlinks them withos.remove()while leaving the target untouched; the linked-directory test now covers both recursive modes.Fixes #1299
Test:
python -m pytest -q fsspec/implementations/tests/test_local.py(140 passed, 16 skipped)