Close cached readers when exiting an open_files context - #2131
Open
betacatsling wants to merge 1 commit into
Open
Close cached readers when exiting an open_files context#2131betacatsling wants to merge 1 commit into
betacatsling wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exiting an
open_filescontext leavessimplecacheandfilecachereaders open becauseopen_many()returns handles without populating theOpenFilewrappers. Close those handles on exit, including when the consumer raises an exception.Regression coverage exercises both cache implementations, normal and exceptional exits, and cold and warm cache reads. The four regressions fail on the unchanged base and pass with the fix. Local validation: cached-filesystem and core suites 137 passed, 37 skipped; Ruff lint/format and
git diff --checkpassed. Remote backends and downstream suites were not run.AI assistance was used for implementation and local verification.
Fixes #2130.