Skip to content

Conversation

@isidentical
Copy link
Member

No description provided.

@isidentical
Copy link
Member Author

Oh, I thought 3.6 was already supported (judging by the classifiers) but apparently it is not; #522. This might be a dead cause

@martindurant
Copy link
Member

You would need to change python_requires= in setup.py to get the CI to run. The classifiers have not been updates since the last release.

@isidentical
Copy link
Member Author

You would need to change python_requires= in setup.py to get the CI to run.

Yes, I am aware. I thought it was the 3.6>= before I made the PR, and I am a bit confused now regarding the official status of support.

@martindurant
Copy link
Member

Indeed, it seems a little unfortunate. The selectors are certainly not authoritative, but This could have been a more public discussion. If py36 support is easy, I am not opposed to continuing with it.

@isidentical isidentical marked this pull request as draft March 18, 2021 19:19
@isidentical isidentical marked this pull request as ready for review March 18, 2021 20:15
@isidentical
Copy link
Member Author

Apparently all tests pass, though pyarrow seems to be a bit problematic when installed in <1, is there anything I should be aware when bumping it to 1>=?

@martindurant
Copy link
Member

Do you mean pyarrow -> v>1.0? That should be OK. The HDFS implementation is slated to be dropped, but not yet.

@isidentical
Copy link
Member Author

yep

@martindurant
Copy link
Member

OK, thanks for doing this - let's keep py36 alive a little longer!

@martindurant martindurant merged commit 9a5d56f into fsspec:master Mar 18, 2021
@isidentical
Copy link
Member Author

Thanks @martindurant!

efiop added a commit that referenced this pull request Jan 15, 2022
3.6 has reached the EOL.

fsspec (along with pydata) dropped support for it early 2021, but we brought
it back for dvc in #575.
@efiop efiop mentioned this pull request Jan 15, 2022
efiop added a commit that referenced this pull request Jan 15, 2022
3.6 has reached the EOL.

fsspec (along with pydata) dropped support for it early 2021, but we brought
it back for dvc in #575.
martindurant pushed a commit that referenced this pull request Jan 18, 2022
3.6 has reached the EOL.

fsspec (along with pydata) dropped support for it early 2021, but we brought
it back for dvc in #575.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants