drop python 3.6 #889
drop python 3.6 #889
Conversation
3.6 has reached the EOL. fsspec (along with pydata) dropped support for it early 2021, but we brought it back for dvc in #575.
|
Would you say that there's still some ongoing cost to supporting py36? |
|
@martindurant I'm mostly worried about async stuff, tbh, as it lacks features in 3.6 and is hard to test, so some code might be broken on 3.6 and we wouldn't even know it. Also 3.6 CI is x2 as slow as 3.7. So overall, 3.6 drop will improve developer experience and maintainablity. It is nice to slowly get rid of dead weight. As to dvc, we've dropped 3.6 a few months back and it also mostly was some dead weight. Nothing as major or critical as 3.5 drop. |
|
OK, sounds like good justification to me. Let's keep this up for a day for any dissent. |
|
OK, merging now, good-bye python3.6. Follow-up: I think s3fs and gcsfs might still say they support 3.6 (but after this PR is released, they will not be installable there). |
Following fsspec/filesystem_spec#889 3.6 wasn't even tested in CI.
Following fsspec/filesystem_spec#889 3.6 wasn't even tested in CI.
3.6 has reached the EOL.
fsspec (along with pydata) dropped support for it early 2021, but we brought
it back for dvc in #575.