arrow: introduce Arrow wrapper - #754
Merged
Merged
Conversation
isidentical
force-pushed
the
pyarrow
branch
from
September 13, 2021 18:26
9ab0ce4 to
2919679
Compare
efiop
reviewed
Sep 13, 2021
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
Contributor
There was a problem hiding this comment.
Cool, thanks a lot for picking up my initial implementation!
| "github": ["requests"], | ||
| "gs": ["gcsfs"], | ||
| "hdfs": ["pyarrow >= 1"], | ||
| "arrow": ["pyarrow >= 1"], |
Member
There was a problem hiding this comment.
also call this arrow_hdfs?
Member
Author
There was a problem hiding this comment.
well technically it is the ArrowWrapper what are you are getting, so unsure about this but also makes sense if HadoopFileSystem is all we are going to export from it.
Member
|
Thanks for reviewing @jorisvandenbossche - you can have the final OK on this one. |
Contributor
|
Thanks @isidentical! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #663 (based on the initial work done by @jorisvandenbossche).
TODO: