test(gui): give the e2e desktop window a 16:9 shape - #380
Merged
Conversation
DESKTOP_WINDOW was 1000x970, which is 1.03:1 -- very nearly square, and no monitor is. The captures came out 1250x1213, so anything displaying them at 16:9 cropped the bottom third: the detail pane, the command strip and the status bar, which is every part of the window a screenshot of a scan is taken for. Felix hit exactly that reading the artifacts. 1600x900 instead. Captures are now 2000x1125 at the harness's 1.25 device pixel ratio, which is 16:9 exactly. NARROW_WINDOW is untouched at 520x720. Its shape is the point rather than an oversight -- it exists to exercise the responsive breakpoint, and its capture stays 650x900. Verified by running the suite at the new size: exit 0, no assertion errors, and no alignment drift reported, so nothing in the layout checks depended on the old dimensions. All 11 desktop captures are 2000x1125 and the narrow one is unchanged. eslint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESKTOP_WINDOWwas 1000x970 — a ratio of 1.03:1, very nearly square, and no monitor is. The captures came out 1250x1213, so anything displaying them at 16:9 cropped the bottom third: the detail pane, the command strip and the status bar. That's every part of the window a screenshot of a scan is taken for.Now 1600x900, so captures are 2000x1125 at the harness's 1.25 device pixel ratio — 16:9 exactly.
NARROW_WINDOWis untouched at 520x720. Its shape is the point rather than an oversight: it exercises the responsive breakpoint, and its capture stays 650x900.Verification
Ran the suite at the new size:
eslintclean