fix: drop incorrect "sdkconfig is git-ignored" claim, document wireguard_lwip divergence - #2
Merged
Merged
Conversation
…ard_lwip divergence The Credentials menu in components/microlink/Kconfig asserted as fact that sdkconfig "should be git-ignored" — true for this repo's own examples, but false for any consumer that intentionally tracks sdkconfig in git and protects credentials some other way (a CI guard script, an ignored overlay file, etc). A downstream consumer (zen-clock) tracks sdkconfig and had to build a check_secrets.py guard specifically because this text put the wrong expectation in front of users configuring the component via menuconfig. Reworded to state where the value is stored without prescribing how a consuming project must handle version control. components/wireguard_lwip/README.md documented only the upstream URL, with no warning that this copy has diverged (own allowed_source_ips[] array replacing upstream's single allowed_ip/allowed_mask, plus the ESP-IDF 6.x/GCC 15 patches and WG_DEBUG logging) and no procedure for checking upstream for new fixes. Added both, plus the result of the 2026-08-10 upstream check: three commits past the divergence point, all already present here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fudio101
added a commit
that referenced
this pull request
Aug 19, 2026
Issue #23 (captive-portal detection) was closed and merged via PR #48 on 2026-08-18 but the tracker table was never updated to reflect it — the only row still missing a done marker. Also prunes the Notes section's two "conflicts to resolve before scoping" callouts (#11, #2-vs-#17), both already resolved in their own rows. Co-authored-by: Adrian.Nguyen-Qualgo <nguyen.ndt@qualgo.net> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, unrelated fixes found while auditing
zen-clock(a consumer of this component).components/microlink/Kconfig— credential comment overstatedThe
Credentialsmenu asserted as fact that sdkconfig "should be git-ignored" (1commentline + 3helptexts). That's true for this repo's own examples, but not universally —zen-clockintentionally trackssdkconfigin git and instead runs a guard script (check_secrets.py) before every commit that fails if a credential Kconfig is non-empty. The old wording put the wrong expectation in front of anyone configuring this component viamenuconfigin a project that doesn't gitignore sdkconfig. Reworded to state where the value lives without prescribing how a consuming project must handle version control.components/wireguard_lwip/README.md— no divergence warning, no upstream-check procedureOnly had the upstream URL. Added:
allowed_source_ips[]array vs upstream's singleallowed_ip/allowed_mask, plus the ESP-IDF 6.x/GCC 15 patches andWG_DEBUGlogging) — future syncs are manual merges, not fast-forwards.git remote add smartalock ...+git logprocedure for checking upstream, so it doesn't need to be rediscovered.Verification
Built
zen-clock(a real consumer) against this branch — clean build, no Kconfig errors:🤖 Generated with Claude Code