Skip to content

cutover to fnm - #189

Merged
fulldecent merged 1 commit into
mainfrom
nvm-to-fnm
Aug 24, 2026
Merged

cutover to fnm#189
fulldecent merged 1 commit into
mainfrom
nvm-to-fnm

Conversation

@fulldecent

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings August 24, 2026 19:11
@fulldecent
fulldecent merged commit db35687 into main Aug 24, 2026
6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The .gitignore exceptions remain ineffective while the parent /.yarn directory is ignored.

Pull request overview

This PR standardizes Node.js management around fnm and Node 24 across development and CI.

Changes:

  • Replaces .nvmrc with .node-version.
  • Updates README, workflows, and Dev Container configuration.
  • Refreshes .gitignore entries.
File summaries
File Summary
README.md Documents fnm-based Node.js setup.
.nvmrc Removes the legacy Node.js version file.
.node-version Adds the Node.js 24 pin.
.gitignore Updates generated-file exclusions; re-inclusion rules are currently ineffective.
.github/workflows/code-lint.yml Uses the new Node version file and Yarn caching.
.github/workflows/build-test-deploy.yml Uses the new Node version file and Yarn caching.
.devcontainer/devcontainer.json Pins the Dev Container Node.js feature to 24.
Review details

Suppressed comments (1)

README.md:37

  • These commands assume that fnm shell integration has already been configured, but the setup steps do not configure it. fnm use cannot change the parent shell's PATH on its own, so with a common manual or Homebrew installation the following yarn install may still use a different Node.js (or no Node.js). Add the shell-specific fnm env initialization or state it as a prerequisite before asking users to rely on .node-version.
   fnm use
  • Files reviewed: 6/7 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants