cutover to fnm - #189
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The .gitignore exceptions remain ineffective while the parent /.yarn directory is ignored.
Pull request overview
This PR standardizes Node.js management around fnm and Node 24 across development and CI.
Changes:
- Replaces
.nvmrcwith.node-version. - Updates README, workflows, and Dev Container configuration.
- Refreshes
.gitignoreentries.
File summaries
| File | Summary |
|---|---|
README.md |
Documents fnm-based Node.js setup. |
.nvmrc |
Removes the legacy Node.js version file. |
.node-version |
Adds the Node.js 24 pin. |
.gitignore |
Updates generated-file exclusions; re-inclusion rules are currently ineffective. |
.github/workflows/code-lint.yml |
Uses the new Node version file and Yarn caching. |
.github/workflows/build-test-deploy.yml |
Uses the new Node version file and Yarn caching. |
.devcontainer/devcontainer.json |
Pins the Dev Container Node.js feature to 24. |
Review details
Suppressed comments (1)
README.md:37
- These commands assume that fnm shell integration has already been configured, but the setup steps do not configure it.
fnm usecannot change the parent shell's PATH on its own, so with a common manual or Homebrew installation the followingyarn installmay still use a different Node.js (or no Node.js). Add the shell-specificfnm envinitialization or state it as a prerequisite before asking users to rely on.node-version.
fnm use
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.