fix(#1142): change DefaultAppSet from "fullsend" to "fullsend-ai"#1180
Merged
Conversation
The official GitHub Apps maintained by the fullsend-ai organization use the "fullsend-ai" prefix (fullsend-ai-fullsend, fullsend-ai-coder, etc.). Update the default so installs use the official apps without requiring an explicit --app-set flag. Orgs with existing "fullsend" app sets must now pass --app-set fullsend explicitly. Closes #1142 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Site previewPreview: https://51e5a664-site.fullsend-ai.workers.dev Commit: |
ReviewNo findings. Previous runReviewNo findings. Previous run (2)ReviewFindingsLow
Previous run (3)ReviewFindingsMedium
Low
Previous run (4)ReviewFindingsHigh
Medium
Low
|
TestInstallCmd_Flags and TestUninstallCmd_Flags still asserted the old "fullsend" default value for --app-set after the constant was changed to "fullsend-ai". Signed-off-by: Wayne Sun <gsun@redhat.com>
fullsend-ai-review
Bot
added
the
requires-manual-review
ralphbean
approved these changes
May 19, 2026
Contributor
ralphbean
left a comment
ralphbean
left a comment
There was a problem hiding this comment.
The [documentation-currency] finding is a good find; otherwise +1, thanks for this.
- Update installation.md flag tables and custom app sets section to
reflect the new "fullsend-ai" default
- Use "myorg" as the example prefix in --app-set help text since
"fullsend-ai" is now the actual default
- Fix TestAgentAppConfig_CustomAppSet to use a truly custom prefix
("my-custom") so it doesn't duplicate the default test
- Update stale comments in e2e cleanup to match new convention
Signed-off-by: Wayne Sun <gsun@redhat.com>
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
Review follow-upsCreated follow-up issues for actionable non-blocking review findings:
|
fullsend-ai-review
Bot
added
ready-for-merge
Update ADR 0033 slug examples and default value, fix cli-internals
diagram to show {appSet}-{role}, rewrite installation.md example to
use a non-default app-set, add migration note for existing users,
and clarify a misleading test case name.
Signed-off-by: Wayne Sun <gsun@redhat.com>
fullsend-ai-review
Bot
added
ready-for-merge
Keep the explicit flag to push users toward the fullsend-ai app set. Signed-off-by: Wayne Sun <gsun@redhat.com>
Signed-off-by: Wayne Sun <gsun@redhat.com>
fullsend-ai-review
Bot
added
ready-for-merge
4 tasks
ifireball
pushed a commit
to ifireball/fullsend
that referenced
this pull request
May 25, 2026
Add step 8 to the planning phase of the code-implementation skill instructing the agent to search for old literal values when changing constants or defaults. When the task changes a constant from X to Y, the agent now searches for both the symbol name and the old value X as a string literal in test files, docs, and config. This addresses missed hardcoded assertions like those found in PR fullsend-ai#1180. Note: make lint could not run (Go toolchain permission denied in sandbox). Change is documentation-only (Markdown). Closes fullsend-ai#1221 Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official GitHub Apps maintained by the fullsend-ai organization use the "fullsend-ai" prefix (fullsend-ai-fullsend, fullsend-ai-coder, etc.). Update the default so installs use the official apps without requiring an explicit --app-set flag. Orgs with existing "fullsend" app sets must now pass --app-set fullsend explicitly.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Closes #1142
Post-script verification
fullsend/code/issue-1142)5f4e79e1610ae3ce8e8bcf95d530c1974ae6fcc1..HEAD)