Skip to content

chore(skills): update cutting-releases for fullsend-ai @main switch#1968

Merged
ralphbean merged 3 commits into
mainfrom
chore/update-cutting-releases-fullsend-ai-main
Jun 8, 2026
Merged

chore(skills): update cutting-releases for fullsend-ai @main switch#1968
ralphbean merged 3 commits into
mainfrom
chore/update-cutting-releases-fullsend-ai-main

Conversation

@ralphbean

Copy link
Copy Markdown
Member

Summary

  • fullsend-ai/.fullsend now uses @main instead of @v0 for reusable workflows
  • Pre-flight: added step E to check fullsend-ai runs as a signal that main is healthy before moving v0
  • Post-flight: replaced the fullsend-ai verification step with an explanatory note (those runs don't exercise v0 anymore) and made downstream checks self-contained

🤖 Generated with Claude Code

fullsend-ai/.fullsend now references reusable workflows via @main
instead of @v0. This means:

- Pre-flight: fullsend-ai runs are now a signal that main is healthy
  before moving the v0 tag (new step E)
- Post-flight: fullsend-ai runs no longer tell us anything about v0
  resolution, so step C is replaced with an explanatory note and
  downstream verification is moved to step D with inline commands

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Site preview

Preview: https://4bb8db19-site.fullsend-ai.workers.dev

Commit: 9e42931667d96c2435d8dbd912e3c0e1e387467d

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] skills/cutting-releases/post-flight.md, skills/cutting-releases/pre-flight.md — Both modified files are under skills/, a protected path requiring human approval. The PR has no linked issue authorizing changes to governance/infrastructure files. Human review is required for all protected-path changes regardless of context.
    Remediation: Link this PR to an issue authorizing the change to protected skill files, or obtain explicit human approval.

Low

  • [logic-error] skills/cutting-releases/pre-flight.md:112 — New step E lists gh run list --repo fullsend-ai/fullsend --limit=5, but step D already runs gh run list --branch=main --limit=5 against the same repo (fullsend-ai/fullsend is the current repo). Only the .fullsend repo check in step E adds new information; the fullsend repo check is redundant with step D.
    Remediation: Remove the gh run list --repo fullsend-ai/fullsend --limit=5 line from step E, keeping only the .fullsend repo check.

  • [internal-consistency] skills/cutting-releases/pre-flight.md:138 — The note after step F ("fullsend-ai/.fullsend uses @main, not @v0, so its runs are not useful for post-flight v0 verification") duplicates the rationale already stated in step E (lines 104–106). This creates a maintenance risk if one copy is updated without the other.
    Remediation: Remove the redundant note after step F, or replace it with a brief cross-reference to step E.

Info

  • [missing-authorization] skills/cutting-releases/post-flight.md — No linked issue for a non-trivial change (~92 lines across 2 files). The change is a maintenance chore updating procedural docs to match an already-implemented infrastructure change (fullsend-ai switching to @main, confirmed in .github/workflows/fullsend.yaml). The PR body provides clear rationale. While a linked issue would strengthen traceability, the corrective nature of this documentation update reduces the significance of the authorization gap.

  • [prior-finding-resolved] skills/cutting-releases/post-flight.md:55 — Prior finding about step D missing the gh run rerun command template is resolved. The new step D now includes the full rerun command block, user-facing prompt template, and gh run list commands — it is self-contained.

Previous run

Review

Findings

High

  • [protected-path] skills/cutting-releases/post-flight.md, skills/cutting-releases/pre-flight.md — Both modified files are under skills/, a protected path requiring human approval. The PR has no linked issue and does not explain why governance/infrastructure files specifically need modification. Human review is required for all protected-path changes regardless of context.
    Remediation: Link this PR to an issue authorizing the change to protected skill files, and note in the PR description why these governance files need updating.

Medium

  • [missing-authorization] skills/cutting-releases/post-flight.md — Non-trivial structural change (~93 lines, step reorganization across 2 files) without a linked issue. The change appears to be a maintenance chore updating procedural docs to match an already-occurred infrastructure change (fullsend-ai switching to @main), but non-trivial changes require explicit authorization via a linked issue. See also: [protected-path] finding above.
    Remediation: Create or link an issue documenting why the cutting-releases skill needs updating to reflect the fullsend-ai @main switch.

  • [logic-error] skills/cutting-releases/post-flight.md:62 — Step D instructs the agent to "present any candidate to the user for confirmation before retriggering" but omits the gh run rerun command template and the user-facing prompt format that were present in the old step C. While Bash(gh run:*) is in the skill's allowed-tools, the procedural doc should be self-contained so the agent has the exact command pattern.
    Remediation: Add the rerun command block and prompt template to step D, adapted for the generic <org/repo> variable. For example: gh run rerun <run-id> --failed --repo <org/repo> with a preceding prompt like "> I found run <run-id> (failed) in <org/repo>. Retrigger it to verify @v0 resolves?"

Low

  • [documentation-structure] skills/cutting-releases/post-flight.md:32 — The heading ## C. Note on fullsend-ai repos uses an informational "Note on" prefix that breaks the action-verb pattern established by all other lettered steps (e.g., "Check", "Wait for", "Verify", "Present"). Since step C is now informational rather than procedural, consider either removing the lettered heading (making it a note paragraph after step B) or retitling to match the action pattern (e.g., "## C. Skip fullsend-ai repos").

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.


Use `AskUserQuestion` to ask if the user has access to additional
downstream orgs:
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] logic-error

Step D instructs the agent to present a candidate for retriggering but omits the gh run rerun command template and user-facing prompt format that were in the old step C. The procedural doc should include the command pattern for self-containment.

Suggested fix: Add the rerun command block (gh run rerun --failed --repo <org/repo>) and prompt template to step D.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9e42931. Added the rerun command block and prompt template.

Comment thread skills/cutting-releases/post-flight.md Outdated
Verify the release is not marked as a draft.

## C. Check fullsend-ai repos
## C. Note on fullsend-ai repos

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] documentation-structure

Heading '## C. Note on fullsend-ai repos' uses informational 'Note on' prefix breaking the action-verb pattern of all other lettered steps. Consider removing the letter or retitling to 'Skip fullsend-ai repos'.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9e42931. Renamed to "Skip fullsend-ai repos".

- Rename heading to "Skip fullsend-ai repos" to match action-verb pattern
- Add rerun command template and prompt to step D for self-containment

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean ralphbean changed the title Update cutting-releases skill for fullsend-ai @main switch chore(skills): update cutting-releases for fullsend-ai @main switch Jun 5, 2026

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

exact commit we are about to tag. Use this as a pre-flight signal:

```
gh run list --repo fullsend-ai/.fullsend --limit=5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] logic-error

New step E lists 'gh run list --repo fullsend-ai/fullsend --limit=5', but step D already runs 'gh run list --branch=main --limit=5' against the same repo. Only the .fullsend repo check adds new information.

Suggested fix: Remove the redundant fullsend-ai/fullsend check from step E, keeping only the .fullsend repo check.


## F. Present summary
Note: `fullsend-ai/.fullsend` uses `@main`, not `@v0`, so its runs
are not useful for post-flight `v0` verification. Post-flight checks

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] internal-consistency

The note after step F duplicates the rationale already stated in step E about fullsend-ai/.fullsend using @main. Creates maintenance risk if one copy is updated without the other.

Suggested fix: Remove the redundant note or replace with a cross-reference to step E.

```
gh run list --repo fullsend-ai/fullsend --limit=3
gh run list --repo fullsend-ai/.fullsend --limit=3
gh run list --repo <org/repo> --limit=5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] prior-finding-resolved

Prior finding about step D missing rerun command template is resolved. The new step D is now self-contained with full command blocks and prompt templates.

@ralphbean ralphbean added this pull request to the merge queue Jun 8, 2026
@fullsend-ai-review

Copy link
Copy Markdown

🤖 Review · Started 3:36 PM UTC
Commit: d0ac11b · View workflow run →

Merged via the queue into main with commit b1fdcec Jun 8, 2026
3 checks passed
@ralphbean ralphbean deleted the chore/update-cutting-releases-fullsend-ai-main branch June 8, 2026 15:37
@fullsend-ai-retro

Copy link
Copy Markdown

🤖 Retro · Started 3:38 PM UTC
Commit: d0ac11b · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #1968chore(skills): update cutting-releases for fullsend-ai @main switch

Workflow type: Human-authored chore PR reviewed by the review agent (no code agent involvement).

Timeline

  1. 2026-06-05 20:30ralphbean opens PR updating cutting-releases skill docs for @main switch.
  2. 2026-06-05 20:40 — Review bot round 1: CHANGES_REQUESTED with 1 medium (missing rerun command template) and 1 low (heading naming pattern) finding. Both valid.
  3. 2026-06-05 20:42 — Author fixes both findings in commit 9e42931 (2 minutes turnaround).
  4. 2026-06-05 20:51 — Review bot round 2: CHANGES_REQUESTED again with 2 new low-severity findings (redundant repo check, duplicated rationale). Confirmed prior findings resolved.
  5. 2026-06-08 06:53 — Human rh-hemartin approves, overriding the bot's CHANGES_REQUESTED.
  6. 2026-06-08 15:37 — PR merged.

Assessment

The review bot performed well in round 1 — both findings were actionable and the author agreed. Round 2 correctly acknowledged the fixes but then filed CHANGES_REQUESTED again for two new low-severity findings. This forced the PR to wait for a human override, adding ~34 hours of latency (mostly weekend, but still unnecessary friction).

Several improvement areas are already covered by existing open issues:

One proposal below addresses the round-2 verdict threshold, which is adjacent to but not fully covered by existing issues #1068 (governance-only findings) and #870 (medium findings should block).

Proposals filed

@fullsend-ai-retro

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 3:38 PM UTC · Completed 3:44 PM UTC
Commit: d0ac11b · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open pull requests.

Posted by fullsend post-review check

@fullsend-ai-review

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:36 PM UTC · Completed 3:45 PM UTC
Commit: d0ac11b · View workflow run →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants