fix(sandbox): force executable bit on host_files copied into bin/#343
Merged
Conversation
Site previewPreview: https://47ca10c5-site.fullsend-ai.workers.dev Commit: |
The GitHub Contents API (used by admin install) commits all files as 100644, so scripts like scan-unicode lose their executable bit in the .fullsend repo. When bootstrapEnv() copies these into the sandbox via SCP, they remain non-executable and `test -x` fails. Work around this by forcing chmod +x on any host_file whose destination is under a bin/ directory. This is a stopgap until admin install preserves the git tree mode (see #312). Fixes: appdumpster/test-repo#13 review failure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ralphbean
force-pushed
the
fix/chmod-host-files-in-sandbox
branch
from
f0af993 to
0c8149d
Compare
ralphbean
changed the title
ralphbean
commented
Apr 23, 2026
ralphbean
commented
Apr 23, 2026
Co-authored-by: Ralph Bean <rbean@redhat.com>
ascerra
approved these changes
Apr 23, 2026
6 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin install) commits all files as100644, so scripts likescan-unicodelose their executable bit in the.fullsendrepobootstrapEnv()copies these into the sandbox via SCP, they remain non-executable —test -x $SCAN_UNICODEfails and the review agent aborts withmissing-contextchmod +xon any host_file whose destination is under abin/directoryadmin installpreserves git tree modes (#345 comment)Verified: triggered a review on appdumpster/test-repo with the fix — agent completed successfully and approved the PR.
Test plan
go vetpassesgo test ./internal/cli/...passes🤖 Generated with Claude Code