docs(#4649): replace stale EnsureGateway references with CheckGateway

[fullsend-ai-coder]

The sandbox function EnsureGateway() was renamed to CheckGateway() but three documentation files still referenced the old name.

Updates:

• docs/guides/dev/cli-internals.md: update ASCII flow diagram and
  operations table to use CheckGateway()
• docs/superpowers/specs/...native-sandbox-transport-design.md:
  update unchanged-functions list to use CheckGateway()
• docs/ADRs/0030-openshell-sandbox-interaction-model.md: add minor
  annotation noting the rename (per ADR immutability rules)

Note: pre-commit could not run fully (shellcheck-py failed to install due to sandbox network restrictions, exit code 3). The post-script runs pre-commit authoritatively on the runner.

---

Closes #4649

Post-script verification

• Branch is not main/master (agent/4649-fix-ensuregateway-docs)
• Secret scan passed (gitleaks — 1401da4058ce349086d547cb031f390b0266e684..HEAD)
• Pre-commit hooks passed (authoritative run on runner)
• Tests ran inside sandbox

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[fullsend-ai-retro]

🤖 Finished Retro · ✅ Success · Started 9:49 AM UTC · Completed 10:03 AM UTC
Commit: c317638 · View workflow run →

[fullsend-ai-retro]

PR #4654 was a docs-only fix for stale EnsureGateway references, originating from the retro agent's analysis of PR #4533. The retro→triage→code pipeline executed efficiently in ~15 minutes with zero rework iterations. However, the review agent never ran on this PR due to a known dispatch routing gap (issues #4371 and #3998): bot-authored PRs fail the collaborator permission check, and the post-code.sh label workaround also failed silently. The human reviewer approved and merged without any automated review. The code agent introduced a minor factual inaccuracy in the ADR annotation, citing PR #4533 as the rename PR when it only fixed test comments.

Proposals filed

• Code agent cited wrong PR in ADR annotation: attributed EnsureGateway→CheckGateway rename to PR #4533 which only fixed test comments (in fullsend-ai/fullsend)

Evidence notes (not filed as issues)

• Evidence for Dispatch routing should whitelist internal agent bots for review dispatch on pull_request_target #4371: PR docs(#4649): replace stale EnsureGateway references with CheckGateway #4654 review dispatch skipped due to bot author permission check failure (fullsend-ai/fullsend): PR docs(#4649): replace stale EnsureGateway references with CheckGateway #4654 (authored by fullsend-ai-coder[bot], created 2026-07-14T07:42:05Z) triggered a pull_request_target.opened dispatch at 07:42:09 UTC. The dispatch workflow evaluated is_event_actor_authorized('fullsend-ai-coder[bot]'), which calls the collaborator permission API. The API returned a non-write role for the bot account. The dispatch logged 'No stage matched — skipping dispatch' (workflow run 29315444233, job 87028305137). No review agent ever ran on this PR.
• Evidence for Post-code script should apply ready-for-review label before validation gates to ensure review dispatch on successful PR creation #3998: ready-for-review label applied on PR docs(#4649): replace stale EnsureGateway references with CheckGateway #4654 but no issues.labeled event fired to trigger review dispatch (fullsend-ai/fullsend): PR docs(#4649): replace stale EnsureGateway references with CheckGateway #4654's post-code.sh applied the ready-for-review label at 07:42:06 UTC (confirmed by PR_LABELS: ready-for-review in the pull_request_target.opened dispatch env at 07:42:09). However, no fullsend workflow run with event type 'issues' was observed between 07:42 and 09:47 for issue/PR docs(#4649): replace stale EnsureGateway references with CheckGateway #4654. The review dispatch was never triggered via the issues.labeled path.