adds *httpgrpc.Server#64
Merged
Merged
Conversation
jhump
force-pushed
the
jh/better-httpgrpc-server-api
branch
from
61f9b86 to
b167c89
Compare
dragonsinth
reviewed
Feb 20, 2022
|
|
||
| // Server is a gRPC-over-HTTP server. It acts as a grpc.ServiceRegistrar, | ||
| // for registering server implementations, and also implements http.Handler, | ||
| // for exposing the services via HTTP. |
Member
There was a problem hiding this comment.
Maybe we should add:
var _ reflection.GRPCServer = (*Server)(nil)
var _ http.Handler = (*Server)(nil)
var _ grpc.ServiceRegistrar = (*Server)(nil)
dragonsinth
approved these changes
Feb 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a simpler API for exposing services via gRPC-over-HTTP 1.1.