Conversation
When a lot number or other AI value is long, the composite text label (e.g. "(17)251231(10)VERYLONGLOT") could be wider than the GS1 DataBar symbol. `injectCompositeText` now estimates text width using Courier New monospace metrics (~0.6em/char) and expands the SVG viewBox/width when necessary, centering the barcode within the wider canvas. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: 合成テキストがバーコード幅を超えた場合にSVG幅を拡張する (#3)
This was referenced Apr 28, 2026
fumtas1k
added a commit
that referenced
this pull request
May 31, 2026
レビュー指摘対応。 - OutputField の className/statusClassName/textareaClassName の 3 つの エスケープハッチを単一の fill prop に置換し、内部 DOM 3 層へのレイアウト クラス付与をコンポーネント内にカプセル化(#2) - fill 時は手動リサイズ(resize-y)と h-full の競合を避けるため resize-none を 強制し managed height を保証(#3) - エラー表示で入力カラムが伸びても items-stretch で左右カラム高さが揃うことを 検証する E2E を追加。旧実装(items-start)で fail する陽性対照を確認済み(#4) - 既存「デスクトップ幅で揃う」テストの許容値に根拠コメントを付与(#5) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
injectCompositeTextでCourier Newモノスペースのメトリクス(~0.6em/文字)を使ってテキスト幅を推定するようにしたviewBox/widthを拡張するようにしたtranslate(offsetX, textRowH)で水平中央揃えに配置するようにしたテスト手順
VERYLONGLOTCODE123)を入力 → テキストが全て表示されることを確認関連issue
🤖 Generated with Claude Code