async support with feature - #30
Open
tommasoclini wants to merge 2 commits into
Open
Conversation
Closed
Author
|
@Finomnis what do you think? |
Contributor
|
Features should enable capabilities but they should not remove them (like what you do with the original sync function) Reason is that other libraries might enable features out of your control. But that's a general guideline, if you say this crate is enduser specific, then maybe this might be a solution, yes. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add async processor support using
maybe_async_cfg2on feature "async".I tried running memory.sh and I'm getting weird results, there are 200 more bytes in every measure in every test, but when comparing actual binary size with
cargo sizeoravr-size, the main branch and this branch are equal.I used this command(
avr-objcopy -O ihex binary.elf binary.hex) to get the raw binary, and the two files(old and new) do not differ.